RESOLVED INVALID 157572
incomplete merge of changeset 198592 (bug 155776) into safari-601-branch (changeset 198639, rdar://problem/25332806) 
https://bugs.webkit.org/show_bug.cgi?id=157572
Summary incomplete merge of changeset 198592 (bug 155776) into safari-601-branch (cha...
Tobias Netzel
Reported 2016-05-11 10:58:29 PDT
Since changeset 198256 wasn't merged into safari-601-branch the following change in JSStringJoiner.h is missing - append(jsString->viewWithUnderlyingString(state)); + append(value.toString(&state)->viewWithUnderlyingString(state)); But as avoiding the to call toString() was the whole purpose of changeset 198592, bug 155776 is probably still unsolved for the safari-601-branch.
Attachments
Add attachment proposed patch, testcase, etc.
Tobias Netzel
Comment 1 2016-05-11 11:07:46 PDT
I stumpled upon this because I compiled the safari-601-branch using gcc 5.3, which warned about 'jsString' being set but not used.
Alexey Proskuryakov
Comment 2 2016-05-11 13:14:24 PDT
Thank you Tobias! We'll look into this internally at Apple, so marking INVALID in Bugzilla.
Alexey Proskuryakov
Comment 3 2016-05-11 13:48:18 PDT
To fix the build, you can just delete the line that defines jsString.
Note You need to log in before you can comment on or make changes to this bug.