Bug 157572 - incomplete merge of changeset 198592 (bug 155776) into safari-601-branch (changeset 198639, rdar://problem/25332806)
Summary: incomplete merge of changeset 198592 (bug 155776) into safari-601-branch (cha...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Safari 9
Hardware: Mac Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-11 10:58 PDT by Tobias Netzel
Modified: 2016-05-11 13:48 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Netzel 2016-05-11 10:58:29 PDT
Since changeset 198256 wasn't merged into safari-601-branch the following change in JSStringJoiner.h is missing

- append(jsString->viewWithUnderlyingString(state));
+ append(value.toString(&state)->viewWithUnderlyingString(state));

But as avoiding the to call toString() was the whole purpose of changeset 198592,
bug 155776 is probably still unsolved for the safari-601-branch.
Comment 1 Tobias Netzel 2016-05-11 11:07:46 PDT
I stumpled upon this because I compiled the safari-601-branch using gcc 5.3, which warned about 'jsString' being set but not used.
Comment 2 Alexey Proskuryakov 2016-05-11 13:14:24 PDT
Thank you Tobias!

We'll look into this internally at Apple, so marking INVALID in Bugzilla.
Comment 3 Alexey Proskuryakov 2016-05-11 13:48:18 PDT
To fix the build, you can just delete the line that defines jsString.