Bug 157562 - [curl] curl_easy_setopt(CURLOPT_CONNECT_ONLY) should take a long parameter
Summary: [curl] curl_easy_setopt(CURLOPT_CONNECT_ONLY) should take a long parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-11 02:52 PDT by Fujii Hironori
Modified: 2016-05-11 09:17 PDT (History)
9 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2016-05-11 03:03 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2016-05-11 02:52:03 PDT
[curl] curl_easy_setopt(CURLOPT_CONNECT_ONLY) should take a long parameter

In Source/WebCore/platform/network/curl/SocketStreamHandleCurl.cpp (SocketStreamHandle::startThread),
there is a following code:

> curl_easy_setopt(curlHandle, CURLOPT_CONNECT_ONLY)

Required third argument is missing. This should be

> curl_easy_setopt(curlHandle, CURLOPT_CONNECT_ONLY, 1L)

Documentation: https://curl.haxx.se/libcurl/c/CURLOPT_CONNECT_ONLY.html
Introduced in Bug 144628.
Comment 1 Fujii Hironori 2016-05-11 03:03:19 PDT
Created attachment 278610 [details]
Patch
Comment 2 WebKit Commit Bot 2016-05-11 09:17:51 PDT
Comment on attachment 278610 [details]
Patch

Clearing flags on attachment: 278610

Committed r200687: <http://trac.webkit.org/changeset/200687>
Comment 3 WebKit Commit Bot 2016-05-11 09:17:56 PDT
All reviewed patches have been landed.  Closing bug.