Bug 157560 - Touch.prototype is undefined on iOS
Summary: Touch.prototype is undefined on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 157601
Blocks:
  Show dependency tree / graph
 
Reported: 2016-05-10 22:14 PDT by Ryosuke Niwa
Modified: 2016-05-12 12:53 PDT (History)
10 users (show)

See Also:

Attachments
Refactors code to fix the bug (7.07 KB, patch)
2016-05-10 22:18 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Updated for ToT (7.06 KB, patch)
2016-05-10 22:39 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed typos (7.06 KB, patch)
2016-05-10 22:56 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Removes the attributes (2.52 KB, patch)
2016-05-10 23:09 PDT, Ryosuke Niwa 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-05-10 22:14:17 PDT 
Refactor DOMWindow.idl and DOMWindowCustom.cpp in order to fix a bug that Touch.prototype is undefined.

<rdar://problem/26143008>
Comment 1 Ryosuke Niwa 2016-05-10 22:18:39 PDT 
Created attachment 278586 [details]
Refactors code to fix the bug
Comment 2 Ryosuke Niwa 2016-05-10 22:39:21 PDT 
Created attachment 278589 [details]
Updated for ToT
Comment 3 Chris Dumez 2016-05-10 22:43:10 PDT 
Comment on attachment 278589 [details]
Updated for ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=278589&action=review

> Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:154
> +#if ENABLE(IOS_TOUCH_EVENTS)

I don't think we want to add any properties in this function. Why aren't those properties added automatically if the corresponding interfaces are not marked as [NoInterfaceObject]?

> Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:280
> +    if (propertyName == exec->propertyNames().touch || propertyName == exec->propertyNames().touchList)

I don't think we want any more special handling in this function.
Comment 4 Chris Dumez 2016-05-10 22:44:06 PDT 
Comment on attachment 278589 [details]
Updated for ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=278589&action=review

> Source/JavaScriptCore/runtime/CommonIdentifiers.h:248
> +    macro(touch) \

Why do these start with a lowercase?
Comment 5 Ryosuke Niwa 2016-05-10 22:56:03 PDT 
Created attachment 278590 [details]
Fixed typos
Comment 6 Ryosuke Niwa 2016-05-10 23:09:28 PDT 
Created attachment 278592 [details]
Removes the attributes
Comment 7 Chris Dumez 2016-05-10 23:12:01 PDT 
Comment on attachment 278592 [details]
Removes the attributes

View in context: https://bugs.webkit.org/attachment.cgi?id=278592&action=review

r=me but please coordinate this when landing.

> Source/WebCore/ChangeLog:5
> +

Missing radar number?
Comment 8 Ryosuke Niwa 2016-05-11 13:08:47 PDT 
Committed r200700: <http://trac.webkit.org/changeset/200700>
Comment 9 WebKit Commit Bot 2016-05-11 17:29:19 PDT 
Re-opened since this is blocked by bug 157601
Comment 10 Ryosuke Niwa 2016-05-12 12:53:59 PDT 
Committed r200788: <http://trac.webkit.org/changeset/200788>