Bug 157560 – Touch.prototype is undefined on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

Refactor DOMWindow.idl and DOMWindowCustom.cpp in order to fix a bug that Touch.prototype is undefined.

<rdar://problem/26143008>

[Ryosuke Niwa]

Created attachment 278586 [details]
Refactors code to fix the bug

[Ryosuke Niwa]

Created attachment 278589 [details]
Updated for ToT

[Chris Dumez]

Comment on attachment 278589 [details]
Updated for ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=278589&action=review

> Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:154
> +#if ENABLE(IOS_TOUCH_EVENTS)

I don't think we want to add any properties in this function. Why aren't those properties added automatically if the corresponding interfaces are not marked as [NoInterfaceObject]?

> Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:280
> +    if (propertyName == exec->propertyNames().touch || propertyName == exec->propertyNames().touchList)

I don't think we want any more special handling in this function.

[Chris Dumez]

Comment on attachment 278589 [details]
Updated for ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=278589&action=review

> Source/JavaScriptCore/runtime/CommonIdentifiers.h:248
> +    macro(touch) \

Why do these start with a lowercase?

[Ryosuke Niwa]

Created attachment 278590 [details]
Fixed typos

[Ryosuke Niwa]

Created attachment 278592 [details]
Removes the attributes

[Chris Dumez]

Comment on attachment 278592 [details]
Removes the attributes

View in context: https://bugs.webkit.org/attachment.cgi?id=278592&action=review

r=me but please coordinate this when landing.

> Source/WebCore/ChangeLog:5
> +

Missing radar number?

[Ryosuke Niwa]

Committed r200700: <http://trac.webkit.org/changeset/200700>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 157601

[Ryosuke Niwa]

Committed r200788: <http://trac.webkit.org/changeset/200788>