Bug 157559 – preprocess-idls.pl not ignoring comments during processing

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Rawinder Singh]

Created attachment 278580 [details]
TestPreprocessIssue.idl

During processing of an IDL file with comments in the IDL interface attribute section, I encountered the problem that Source/WebCore/bindings/scripts/preprocess-idls.pl was not ignoring the comments in the attribute section.
According to the Web IDL specification, http://www.w3.org/TR/WebIDL/#idl-grammar, comments should be ignored during processing.

This patch addresses the issue described above.

Steps to reproduce the problem:

1. List test file TestPreprocessIssue.idl in idl_files.tmp:

> [
>    NoInterfaceObject
>    // This is a comment
>] interface  TestPreprocessIssue
>};

This test file specifies that the TestPreprocessIssue interface has the 'NoInterfaceObject' attribute.

2. Run preprocess-idls.pl:

> perl -I WebCore/bindings/scripts/ WebCore/bindings/scripts/preprocess-idls.pl --defines "" --idlFilesList ./idl_files.tmp --supplementalDependencyFile ./SupplementalDependencies.txt --windowConstructorsFile ./DOMWindowConstructors.idl --workerGlobalScopeConstructorsFile ./WorkerGlobalScopeConstructors.idl --dedicatedWorkerGlobalScopeConstructorsFile ./DedicatedWorkerGlobalScopeConstructors.idl --supplementalMakefileDeps SupplementalDependencies.dep

3. The script produces the following DOMWindowConstructors.idl (that is, a constructor is incorrectly created for interface with 'NoInterfaceObject' attribute):

> partial interface DOMWindow {
>   attribute TestPreprocessIssueConstructor TestPreprocessIssue;
> };

* The correct output is:

> partial interface DOMWindow {
>  };

This is caused by preprocess-idls.pl getInterfaceExtendedAttributesFromIDL reading in the key as:

'NoInterfaceObject
    // This is a comment'

and therefore not picking up the 'NoInterfaceObject' interface attribute.

[Rawinder Singh]

Created attachment 278584 [details]
Patch

[Rawinder Singh]

Created attachment 278599 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 278599 [details]
Patch

Clearing flags on attachment: 278599

Committed r200689: <http://trac.webkit.org/changeset/200689>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.