Bug 157538 - Internal JSC profiler should have a timestamped log of events for each code block
Summary: Internal JSC profiler should have a timestamped log of events for each code b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-10 14:58 PDT by Filip Pizlo
Modified: 2016-05-10 17:08 PDT (History)
1 user (show)

See Also:

Attachments
the patch (54.94 KB, patch)
2016-05-10 15:01 PDT, Filip Pizlo 		benjamin: review+
Details | Formatted Diff | Diff
patch for landing (56.32 KB, patch)
2016-05-10 15:21 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
more fixes (57.97 KB, patch)
2016-05-10 15:40 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
even more fixes (59.22 KB, patch)
2016-05-10 15:58 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-05-10 14:58:46 PDT 
This will help us see what is going on in bigger programs.
Comment 1 Filip Pizlo 2016-05-10 15:01:09 PDT 
Created attachment 278534 [details]
the patch
Comment 2 WebKit Commit Bot 2016-05-10 15:03:14 PDT 
Attachment 278534 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/profiler/ProfilerDatabase.h:74:  The parameter name "codeBlock" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/VM.h:617:  The parameter name "func" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Benjamin Poulain 2016-05-10 15:04:14 PDT 
Comment on attachment 278534 [details]
the patch

+1, this looks useful.
Comment 4 Filip Pizlo 2016-05-10 15:21:00 PDT 
Created attachment 278537 [details]
patch for landing
Comment 5 WebKit Commit Bot 2016-05-10 15:22:12 PDT 
Attachment 278537 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/profiler/ProfilerDatabase.h:74:  The parameter name "codeBlock" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/VM.h:617:  The parameter name "func" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Filip Pizlo 2016-05-10 15:40:41 PDT 
Created attachment 278542 [details]
more fixes
Comment 7 WebKit Commit Bot 2016-05-10 15:42:11 PDT 
Attachment 278542 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/profiler/ProfilerDatabase.h:74:  The parameter name "codeBlock" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/VM.h:617:  The parameter name "func" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Filip Pizlo 2016-05-10 15:58:50 PDT 
Created attachment 278543 [details]
even more fixes
Comment 9 WebKit Commit Bot 2016-05-10 16:01:05 PDT 
Attachment 278543 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/profiler/ProfilerDatabase.h:74:  The parameter name "codeBlock" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/VM.h:617:  The parameter name "func" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Filip Pizlo 2016-05-10 17:08:31 PDT 
Landed in http://trac.webkit.org/changeset/200658