RESOLVED FIXED 157538
Internal JSC profiler should have a timestamped log of events for each code block 
https://bugs.webkit.org/show_bug.cgi?id=157538
Summary Internal JSC profiler should have a timestamped log of events for each code b...
Filip Pizlo
Reported 2016-05-10 14:58:46 PDT
This will help us see what is going on in bigger programs.
Attachments
the patch (54.94 KB, patch)
2016-05-10 15:01 PDT, Filip Pizlo 		benjamin: review+
DetailsFormatted DiffDiff
patch for landing (56.32 KB, patch)
2016-05-10 15:21 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
more fixes (57.97 KB, patch)
2016-05-10 15:40 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
even more fixes (59.22 KB, patch)
2016-05-10 15:58 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-05-10 15:01:09 PDT
Created attachment 278534 [details] the patch
WebKit Commit Bot
Comment 2 2016-05-10 15:03:14 PDT
Attachment 278534 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/profiler/ProfilerDatabase.h:74: The parameter name "codeBlock" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/runtime/VM.h:617: The parameter name "func" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 3 2016-05-10 15:04:14 PDT
Comment on attachment 278534 [details] the patch +1, this looks useful.
Filip Pizlo
Comment 4 2016-05-10 15:21:00 PDT
Created attachment 278537 [details] patch for landing
WebKit Commit Bot
Comment 5 2016-05-10 15:22:12 PDT
Attachment 278537 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/profiler/ProfilerDatabase.h:74: The parameter name "codeBlock" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/runtime/VM.h:617: The parameter name "func" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 6 2016-05-10 15:40:41 PDT
Created attachment 278542 [details] more fixes
WebKit Commit Bot
Comment 7 2016-05-10 15:42:11 PDT
Attachment 278542 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/profiler/ProfilerDatabase.h:74: The parameter name "codeBlock" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/runtime/VM.h:617: The parameter name "func" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 8 2016-05-10 15:58:50 PDT
Created attachment 278543 [details] even more fixes
WebKit Commit Bot
Comment 9 2016-05-10 16:01:05 PDT
Attachment 278543 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/profiler/ProfilerDatabase.h:74: The parameter name "codeBlock" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/runtime/VM.h:617: The parameter name "func" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 10 2016-05-10 17:08:31 PDT
Landed in http://trac.webkit.org/changeset/200658
Note You need to log in before you can comment on or make changes to this bug.