RESOLVED WONTFIX 157513
Fix the !ENABLE(ES6_ARROWFUNCTION_SYNTAX) build after r198927 
https://bugs.webkit.org/show_bug.cgi?id=157513
Summary Fix the !ENABLE(ES6_ARROWFUNCTION_SYNTAX) build after r198927
Csaba Osztrogonác
Reported 2016-05-10 06:35:21 PDT
http://trac.webkit.org/changeset/192661 broke the !ENABLE(ES6_ARROW_SYNTAX) build build log: ../../Source/JavaScriptCore/parser/Parser.cpp: In member function 'typename TreeBuilder::Expression JSC::Parser<LexerType>::parseAssignmentExpression(TreeBuilder&, JSC::Parser<LexerType>::ExpressionErrorClassifier&)': ../../Source/JavaScriptCore/parser/Parser.cpp:3090:26: error: 'savePoint' was not declared in this scope savePoint is defined inside ENABLE(ES6_ARROWFUNCTION_SYNTAX) guard, but used without guards. r192661 is a half year old change and nobody noticed this breakage since then. Should we fix this error or should we remove these broken guards?
Attachments
Add attachment proposed patch, testcase, etc.
Caitlin Potter (:caitp)
Comment 1 2016-05-10 06:46:34 PDT
It's broken in trunk, but that changeset does not have this issue. The savePoint was put inside the ENABLE(ES6_ARROW_SYNTAX) guards in http://trac.webkit.org/changeset/198927 several weeks ago. /CC sbarati@apple.com
Csaba Osztrogonác
Comment 2 2016-05-10 06:48:48 PDT
(In reply to comment #1) > It's broken in trunk, but that changeset does not have this issue. > > The savePoint was put inside the ENABLE(ES6_ARROW_SYNTAX) guards in > http://trac.webkit.org/changeset/198927 several weeks ago. > > /CC sbarati@apple.com Really, you're right.
Saam Barati
Comment 3 2016-05-10 08:49:23 PDT
We should just get rid of ENABLE_ES6_ARROW_SYNTAX It's stable now and shouldn't be behind a compile time flag.
Csaba Osztrogonác
Comment 4 2016-05-11 03:10:32 PDT
Filed a new bug report to remove this guard - bug157564 .
Note You need to log in before you can comment on or make changes to this bug.