Bug 157501 – [iOS] <select> elements should render right-aligned when in RTL mode

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Dean Jackson]

This is the equivalent of 157112 for iOS.

[Radar WebKit Bug Importer]

<rdar://problem/26187870>

[Dean Jackson]

Created attachment 278471 [details]
Patch

[Build Bot]

Comment on attachment 278471 [details]
Patch

Attachment 278471 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1296556

New failing tests:
fast/text/international/pop-up-button-text-alignment-and-direction.html
fast/forms/select-writing-direction-natural.html
fast/forms/listbox-bidi-align.html
fast/text/international/bidi-listbox-atsui.html
fast/scrolling/ios/scroll-events-back-forward-after-pageshow.html
fast/text/international/bidi-listbox.html
fast/text/international/bidi-menulist.html

[Build Bot]

Created attachment 278476 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Antoine Quint]

Comment on attachment 278471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278471&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:685
> +        buttonClip = FloatRect(separatorPosition - adjustTop, clip.y() - adjustTop, MenuListButtonPaddingAfter + adjustTop + adjustRight, clip.height() + adjustTop + adjustBottom);

Maybe use a ternary operator here?

[Dean Jackson]

Comment on attachment 278471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278471&action=review

>> Source/WebCore/rendering/RenderThemeIOS.mm:685
>> +        buttonClip = FloatRect(separatorPosition - adjustTop, clip.y() - adjustTop, MenuListButtonPaddingAfter + adjustTop + adjustRight, clip.height() + adjustTop + adjustBottom);
> 
> Maybe use a ternary operator here?

I didn't use one because the line is already crazyily long.

[Dean Jackson]

Committed r200620: <http://trac.webkit.org/changeset/200620>