Bug 157495 - Draw border and correct icon for placeholder attachments
Summary: Draw border and correct icon for placeholder attachments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-09 16:21 PDT by Tim Horton
Modified: 2016-05-09 16:48 PDT (History)
6 users (show)

See Also:


Attachments
Patch (21.32 KB, patch)
2016-05-09 16:22 PDT, Tim Horton
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2016-05-09 16:21:42 PDT
Draw border and correct icon for placeholder attachments
Comment 1 Tim Horton 2016-05-09 16:22:23 PDT
Created attachment 278454 [details]
Patch
Comment 2 Tim Horton 2016-05-09 16:23:03 PDT
rdar://problem/19982510
Comment 3 Anders Carlsson 2016-05-09 16:42:57 PDT
Comment on attachment 278454 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278454&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:2559
> +    DashArray dashes({attachmentPlaceholderBorderDashLength});
> +    context.setLineDash(dashes, 0);

Do you really need the local variable here?
Comment 4 Tim Horton 2016-05-09 16:48:10 PDT
http://trac.webkit.org/changeset/200596