WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
157495
Draw border and correct icon for placeholder attachments
https://bugs.webkit.org/show_bug.cgi?id=157495
Summary
Draw border and correct icon for placeholder attachments
Tim Horton
Reported
2016-05-09 16:21:42 PDT
Draw border and correct icon for placeholder attachments
Attachments
Patch
(21.32 KB, patch)
2016-05-09 16:22 PDT
,
Tim Horton
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2016-05-09 16:22:23 PDT
Created
attachment 278454
[details]
Patch
Tim Horton
Comment 2
2016-05-09 16:23:03 PDT
rdar://problem/19982510
Anders Carlsson
Comment 3
2016-05-09 16:42:57 PDT
Comment on
attachment 278454
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=278454&action=review
> Source/WebCore/rendering/RenderThemeMac.mm:2559 > + DashArray dashes({attachmentPlaceholderBorderDashLength}); > + context.setLineDash(dashes, 0);
Do you really need the local variable here?
Tim Horton
Comment 4
2016-05-09 16:48:10 PDT
http://trac.webkit.org/changeset/200596
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug