CallObjectConstructor should not call operationToThis in the FTL
Created attachment 278444 [details] Patch
rdar://problem/26149904
Comment on attachment 278444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278444&action=review > Source/JavaScriptCore/ChangeLog:4 > + CallObjectConstructor should not call operationToThis in the FTL > + https://bugs.webkit.org/show_bug.cgi?id=157492 You should have a radar number here, and mention the web site that broke.
Comment on attachment 278444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278444&action=review r=me > Source/JavaScriptCore/ChangeLog:8 > + At some point when I was working on intrinsicifying the Object typo: /intrinsicifying/intrinsifying/. I'm not sure "intrinsifying" is an actual word, but I think it's better than "intrinsicifying". > Source/JavaScriptCore/ChangeLog:9 > + constructor I realized that the Object constructor was different Add a comma after constructor?
Keith, can you also address Simon's feedback?
Comment on attachment 278444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278444&action=review >> Source/JavaScriptCore/ChangeLog:4 >> + https://bugs.webkit.org/show_bug.cgi?id=157492 > > You should have a radar number here, and mention the web site that broke. Ah, I didn't know that was a thing. Fixed. >> Source/JavaScriptCore/ChangeLog:8 >> + At some point when I was working on intrinsicifying the Object > > typo: /intrinsicifying/intrinsifying/. I'm not sure "intrinsifying" is an actual word, but I think it's better than "intrinsicifying". changed. >> Source/JavaScriptCore/ChangeLog:9 >> + constructor I realized that the Object constructor was different > > Add a comma after constructor? fixed.
Created attachment 278453 [details] Patch for landing
Comment on attachment 278453 [details] Patch for landing Clearing flags on attachment: 278453 Committed r200597: <http://trac.webkit.org/changeset/200597>
All reviewed patches have been landed. Closing bug.