Bug 157492 - CallObjectConstructor should not call operationToThis in the FTL
Summary: CallObjectConstructor should not call operationToThis in the FTL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-09 15:31 PDT by Keith Miller
Modified: 2016-05-09 16:50 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.64 KB, patch)
2016-05-09 15:34 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch for landing (3.02 KB, patch)
2016-05-09 16:20 PDT, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-05-09 15:31:10 PDT
CallObjectConstructor should not call operationToThis in the FTL
Comment 1 Keith Miller 2016-05-09 15:34:43 PDT
Created attachment 278444 [details]
Patch
Comment 2 Keith Miller 2016-05-09 15:37:18 PDT
rdar://problem/26149904
Comment 3 Simon Fraser (smfr) 2016-05-09 15:50:45 PDT
Comment on attachment 278444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278444&action=review

> Source/JavaScriptCore/ChangeLog:4
> +        CallObjectConstructor should not call operationToThis in the FTL
> +        https://bugs.webkit.org/show_bug.cgi?id=157492

You should have a radar number here, and mention the web site that broke.
Comment 4 Mark Lam 2016-05-09 15:57:05 PDT
Comment on attachment 278444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278444&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +        At some point when I was working on intrinsicifying the Object

typo: /intrinsicifying/intrinsifying/.  I'm not sure "intrinsifying" is an actual word, but I think it's better than "intrinsicifying".

> Source/JavaScriptCore/ChangeLog:9
> +        constructor I realized that the Object constructor was different

Add a comma after constructor?
Comment 5 Mark Lam 2016-05-09 16:00:34 PDT
Keith, can you also address Simon's feedback?
Comment 6 Keith Miller 2016-05-09 16:04:59 PDT
Comment on attachment 278444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278444&action=review

>> Source/JavaScriptCore/ChangeLog:4
>> +        https://bugs.webkit.org/show_bug.cgi?id=157492
> 
> You should have a radar number here, and mention the web site that broke.

Ah, I didn't know that was a thing. Fixed.

>> Source/JavaScriptCore/ChangeLog:8
>> +        At some point when I was working on intrinsicifying the Object
> 
> typo: /intrinsicifying/intrinsifying/.  I'm not sure "intrinsifying" is an actual word, but I think it's better than "intrinsicifying".

changed.

>> Source/JavaScriptCore/ChangeLog:9
>> +        constructor I realized that the Object constructor was different
> 
> Add a comma after constructor?

fixed.
Comment 7 Keith Miller 2016-05-09 16:20:31 PDT
Created attachment 278453 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2016-05-09 16:50:33 PDT
Comment on attachment 278453 [details]
Patch for landing

Clearing flags on attachment: 278453

Committed r200597: <http://trac.webkit.org/changeset/200597>
Comment 9 WebKit Commit Bot 2016-05-09 16:50:36 PDT
All reviewed patches have been landed.  Closing bug.