Bug 157488 - Web Inspector: Cleanup super getter/setter now that underlying issue is fixed
Summary: Web Inspector: Cleanup super getter/setter now that underlying issue is fixed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-09 13:44 PDT by Joseph Pecoraro
Modified: 2016-05-10 11:49 PDT (History)
10 users (show)

See Also:

Attachments
Patch (8.08 KB, patch)
2016-05-10 00:41 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (708.76 KB, application/zip)
2016-05-10 02:33 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-09 13:44:05 PDT 
Cleanup super getter/setter now that underlying issue is fixed:

Bug 147064 is fixed, so that means we should be able to address these FIXMEs:

    Views/VisualStyleKeywordPicker.js
    56:        // FIXME: <https://webkit.org/b/147064> Getter and setter on super are called with wrong "this" object
    62:        // FIXME: <https://webkit.org/b/147064> Getter and setter on super are called with wrong "this" object
    76:        // FIXME: <https://webkit.org/b/147064> Getter and setter on super are called with wrong "this" object

    Views/VisualStyleNumberInputBox.js
    218:        // FIXME: <https://webkit.org/b/147064> Getter and setter on super are called with wrong "this" object
Comment 1 Radar WebKit Bug Importer 2016-05-09 13:44:43 PDT 
<rdar://problem/26179120>
Comment 2 Devin Rousso 2016-05-10 00:41:42 PDT 
Created attachment 278483 [details]
Patch
Comment 3 Build Bot 2016-05-10 02:33:00 PDT 
Comment on attachment 278483 [details]
Patch

Attachment 278483 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1297702

New failing tests:
fast/scrolling/ios/scroll-events-back-forward-after-pageshow.html
Comment 4 Build Bot 2016-05-10 02:33:02 PDT 
Created attachment 278485 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 5 BJ Burg 2016-05-10 09:44:49 PDT 
Comment on attachment 278483 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2016-05-10 10:42:10 PDT 
Comment on attachment 278483 [details]
Patch

Clearing flags on attachment: 278483

Committed r200629: <http://trac.webkit.org/changeset/200629>
Comment 7 WebKit Commit Bot 2016-05-10 10:42:15 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Joseph Pecoraro 2016-05-10 11:49:09 PDT 
Comment on attachment 278483 [details]
Patch

Nice! Thanks for updating this, I had written a patch locally and it wasn't as complete as this =)