Bug 157478 - Web Inspector: Remove Global Breakpoints folder
Summary: Web Inspector: Remove Global Breakpoints folder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-09 12:01 PDT by Timothy Hatcher
Modified: 2016-05-09 17:01 PDT (History)
8 users (show)

See Also:

Attachments
[Image] UI without folder (134.18 KB, image/png)
2016-05-09 15:45 PDT, Matt Baker 		no flags Details
[Patch] Proposed Fix (6.45 KB, patch)
2016-05-09 15:49 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2016-05-09 12:01:51 PDT 
We should have a flat list of the global breakpoints.
Comment 1 Radar WebKit Bug Importer 2016-05-09 12:02:39 PDT 
<rdar://problem/26176524>
Comment 2 Matt Baker 2016-05-09 12:42:04 PDT 
While we're simplifying Global Breakpoints, does it make sense for these to be selectable? Maybe clicking anywhere in the tree item should just toggle the breakpoint status.
Comment 3 Timothy Hatcher 2016-05-09 14:54:04 PDT 
(In reply to comment #2)
> While we're simplifying Global Breakpoints, does it make sense for these to
> be selectable? Maybe clicking anywhere in the tree item should just toggle
> the breakpoint status.

Space bar will toggle them, so I think we should keep them keyboard reachable.
Comment 4 Matt Baker 2016-05-09 15:45:15 PDT 
Created attachment 278449 [details]
[Image] UI without folder

My feeling is that a divider line isn't necessary between "special" and "user" breakpoints
Comment 5 Matt Baker 2016-05-09 15:49:02 PDT 
Created attachment 278451 [details]
[Patch] Proposed Fix
Comment 6 WebKit Commit Bot 2016-05-09 17:01:43 PDT 
Comment on attachment 278451 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 278451

Committed r200600: <http://trac.webkit.org/changeset/200600>
Comment 7 WebKit Commit Bot 2016-05-09 17:01:46 PDT 
All reviewed patches have been landed.  Closing bug.