Bug 157475 - REGRESSION (198056): Unable to use edit buttons on WordPress
Summary: REGRESSION (198056): Unable to use edit buttons on WordPress
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 148695
  Show dependency treegraph
 
Reported: 2016-05-09 08:50 PDT by Ryosuke Niwa
Modified: 2016-05-09 13:10 PDT (History)
9 users (show)

See Also:


Attachments
Renames deepPath to composedPath (9.23 KB, patch)
2016-05-09 10:08 PDT, Ryosuke Niwa
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-05-09 08:50:39 PDT
We need to rename `Event.prototype.deepPath` to `Event.prototype.composedPath`
Comment 1 Ryosuke Niwa 2016-05-09 10:08:43 PDT
Created attachment 278407 [details]
Renames deepPath to composedPath
Comment 2 Antti Koivisto 2016-05-09 10:23:06 PDT
Comment on attachment 278407 [details]
Renames deepPath to composedPath

r=me

This tramples over the existing definition of "composed tree" which we use widely internally. Hope this is the last time the terminology changes.
Comment 3 Ryosuke Niwa 2016-05-09 10:46:15 PDT
Committed r200580: <http://trac.webkit.org/changeset/200580>
Comment 4 Ryan Haddad 2016-05-09 12:48:55 PDT
This change introduced LayoutTest failures:

  fast/xmlhttprequest/xmlhttprequest-get.xhtml [ Failure ]
  http/tests/workers/worker-importScriptsOnError.html [ Failure ]
  inspector/model/remote-object-get-properties.html [ Failure ]

<https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20%28Tests%29/builds/5041>
Comment 5 Ryan Haddad 2016-05-09 13:10:38 PDT
(In reply to comment #4)
> This change introduced LayoutTest failures:
> 
>   fast/xmlhttprequest/xmlhttprequest-get.xhtml [ Failure ]
>   http/tests/workers/worker-importScriptsOnError.html [ Failure ]
>   inspector/model/remote-object-get-properties.html [ Failure ]
> 
> <https://build.webkit.org/builders/
> Apple%20El%20Capitan%20Debug%20WK2%20%28Tests%29/builds/5041>

Rebaselined tests in <https://trac.webkit.org/r200585>