Bug 157473 - [css-grid] Implement auto-repeat computation
Summary: [css-grid] Implement auto-repeat computation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-09 05:34 PDT by Sergio Villar Senin
Modified: 2016-05-10 00:45 PDT (History)
5 users (show)

See Also:

Attachments
Patch (152.49 KB, patch)
2016-05-09 05:51 PDT, Sergio Villar Senin 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2016-05-09 05:34:10 PDT 
[css-grid] Implement auto-repeat computation
Comment 1 Sergio Villar Senin 2016-05-09 05:51:34 PDT 
Created attachment 278403 [details]
Patch
Comment 2 Darin Adler 2016-05-09 12:21:44 PDT 
Comment on attachment 278403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278403&action=review

> Source/WebCore/css/CSSParser.cpp:6013
> +        list.append(*repeatedValues.get());

Should not need .get() here.

> Source/WebCore/css/CSSParser.cpp:6015
> +        for (size_t i = 0; i < repetitions; ++i) {

Since repetitions is an unsigned it seems peculiar to use size_t as the type for the loop.

> Source/WebCore/rendering/RenderGrid.cpp:725
> +    if (LIKELY(!repetitions) || untranslatedIndex < insertionPoint)

Seems excessive to use LIKELY here. Normally we only use those when we have solid evidence they will boost performance.
Comment 3 Sergio Villar Senin 2016-05-10 00:45:31 PDT 
Committed r200618: <http://trac.webkit.org/changeset/200618>