Bug 157469 – Web Inspector: Cleanup issue tree elements in the Debugger sidebar

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Created attachment 278381 [details]
[Image] Large issue icons

* SUMMARY
Cleanup issue tree elements in the Debugger sidebar. Recent TreeOutline and DebuggerSidebarPanel changes have caused two minor bugs:

1. Issue icons are too big (and differ from those used in the dashboard, see screenshot)
2. Issue tree elements aren't removed after clearing the log

[Radar WebKit Bug Importer]

<rdar://problem/26162999>

[Matt Baker]

Created attachment 278382 [details]
[Patch] Proposed Fix

[Matt Baker]

Created attachment 278383 [details]
[Image] Updated issue icons

[Timothy Hatcher]

Comment on attachment 278382 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=278382&action=review

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:908
> -        for (var issueTreeElement of issueTreeElements)
> -            issueTreeElement.parent.removeChild(issueTreeElement);
> +        issueTreeElements.forEach((treeElement) => treeElement.parent.removeChild(treeElement));

I'm not a fan of forEach for loops, even if it is one line.

[WebKit Commit Bot]

Comment on attachment 278382 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 278382

Committed r200574: <http://trac.webkit.org/changeset/200574>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.