Bug 157469 - Web Inspector: Cleanup issue tree elements in the Debugger sidebar
Summary: Web Inspector: Cleanup issue tree elements in the Debugger sidebar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-08 18:10 PDT by Matt Baker
Modified: 2016-05-09 07:58 PDT (History)
8 users (show)

See Also:

Attachments
[Image] Large issue icons (26.63 KB, image/png)
2016-05-08 18:10 PDT, Matt Baker 		no flags Details
[Patch] Proposed Fix (4.20 KB, patch)
2016-05-08 18:17 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
[Image] Updated issue icons (96.87 KB, image/png)
2016-05-08 18:19 PDT, Matt Baker 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-05-08 18:10:13 PDT 
Created attachment 278381 [details]
[Image] Large issue icons

* SUMMARY
Cleanup issue tree elements in the Debugger sidebar. Recent TreeOutline and DebuggerSidebarPanel changes have caused two minor bugs:

1. Issue icons are too big (and differ from those used in the dashboard, see screenshot)
2. Issue tree elements aren't removed after clearing the log
Comment 1 Radar WebKit Bug Importer 2016-05-08 18:10:28 PDT 
<rdar://problem/26162999>
Comment 2 Matt Baker 2016-05-08 18:17:38 PDT 
Created attachment 278382 [details]
[Patch] Proposed Fix
Comment 3 Matt Baker 2016-05-08 18:19:29 PDT 
Created attachment 278383 [details]
[Image] Updated issue icons
Comment 4 Timothy Hatcher 2016-05-09 07:35:51 PDT 
Comment on attachment 278382 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=278382&action=review

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:908
> -        for (var issueTreeElement of issueTreeElements)
> -            issueTreeElement.parent.removeChild(issueTreeElement);
> +        issueTreeElements.forEach((treeElement) => treeElement.parent.removeChild(treeElement));

I'm not a fan of forEach for loops, even if it is one line.
Comment 5 WebKit Commit Bot 2016-05-09 07:58:37 PDT 
Comment on attachment 278382 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 278382

Committed r200574: <http://trac.webkit.org/changeset/200574>
Comment 6 WebKit Commit Bot 2016-05-09 07:58:42 PDT 
All reviewed patches have been landed.  Closing bug.