Bug 15746 - #ifndef ASSERT_DISABLED is no good!
Summary: #ifndef ASSERT_DISABLED is no good!
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-28 22:38 PDT by Geoffrey Garen
Modified: 2007-10-28 23:04 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.84 KB, patch)
2007-10-28 22:46 PDT, Geoffrey Garen
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2007-10-28 22:38:02 PDT
ASSERT_DISABLED is always defined in Mac OS X builds, so code that relies on #ifndef ASSERT_DISABLED to do debugging won't work. We have code like this in, for example, HashTable.h
Comment 1 Geoffrey Garen 2007-10-28 22:46:34 PDT
Created attachment 16933 [details]
Patch

Mac debug and release builds succeed.
Comment 2 Geoffrey Garen 2007-10-28 23:04:55 PDT
Committed revision 27211.