Bug 157457 – Change HTMLSlotElement::assignedNodes to take an IDL dictionary instead of a WebCore::Dictionary

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Darin Adler]

Change HTMLSlotElement::assignedNodes to take a IDL dictionary instead of a WebCore::Dictionary

[Darin Adler]

Created attachment 278353 [details]
Patch

[Darin Adler]

Comment on attachment 278353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278353&action=review

> Source/WebCore/bindings/js/JSDOMConvert.h:54
> +template<> inline bool convert<bool>(JSC::ExecState& state, JSC::JSValue value)
> +{
> +    return value.toBoolean(&state);
> +}

I will rebase since I recently landed a patch that adds this so I don’t need to add it again.

> Source/WebCore/html/HTMLSlotElement.cpp:113
> +Vector<Node*> HTMLSlotElement::assignedNodes(const Optional<AssignedNodesOptions>& options) const

I’ll post a new patch that no longer uses Optional once I land the patch that fixes the use of Optional for dictionaries.

> LayoutTests/fast/shadow-dom/HTMLSlotElement-interface.html:52
> -testSlotOutsideShadowTree(null);
> +testSlotOutsideShadowTree({});

I won’t need any of these LayoutTests changes after fixing the handling of null in dictionaries, which is the patch I am working on right now.

[Darin Adler]

Created attachment 278365 [details]
Patch

[Darin Adler]

OK, back to a nice small, contained patch again.

[Darin Adler]

Nope, forgot to get rid of Optional!

[Darin Adler]

Created attachment 278366 [details]
Patch

[Darin Adler]

OK, that’s better. Ready to review and land now, I think.

[Chris Dumez]

Comment on attachment 278366 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278366&action=review

r=me

> Source/WebCore/html/HTMLSlotElement.cpp:-138
> -    bool bubbles = false;

bubbles had the benefit of matching the DOM spec.

[Darin Adler]

Comment on attachment 278366 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278366&action=review

>> Source/WebCore/html/HTMLSlotElement.cpp:-138
>> -    bool bubbles = false;
> 
> bubbles had the benefit of matching the DOM spec.

Very interesting. I changed this to match Event.idl and Event.h; didn’t realize they were out of sync with the spec.

[Darin Adler]

Committed r200557: <http://trac.webkit.org/changeset/200557>