Bug 157454 - Reduce special handling of XPathNSResolver type in the bindings
Summary: Reduce special handling of XPathNSResolver type in the bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-07 15:02 PDT by Chris Dumez
Modified: 2016-05-07 21:38 PDT (History)
2 users (show)

See Also:

Attachments
Patch (53.56 KB, patch)
2016-05-07 20:28 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-05-07 15:02:53 PDT 
Reduce special handling of XPathNSResolver type in the bindings
Comment 1 Chris Dumez 2016-05-07 20:28:09 PDT 
Created attachment 278349 [details]
Patch
Comment 2 Darin Adler 2016-05-07 21:34:43 PDT 
Comment on attachment 278349 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278349&action=review

> Source/WebCore/xml/XPathParser.h:75
> +            RefPtr<XPathNSResolver> m_resolver;

Is this safe? No reference cycles or anything?
Comment 3 Chris Dumez 2016-05-07 21:37:09 PDT 
(In reply to comment #2)
> Comment on attachment 278349 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=278349&action=review
> 
> > Source/WebCore/xml/XPathParser.h:75
> > +            RefPtr<XPathNSResolver> m_resolver;
> 
> Is this safe? No reference cycles or anything?

Yes, looks safe to me. XPath::Parser is only used as a local variable in Parser::parseStatement(). XPathNSResolver holds no reference to the Parser.
Comment 4 Chris Dumez 2016-05-07 21:38:30 PDT 
Comment on attachment 278349 [details]
Patch

Clearing flags on attachment: 278349

Committed r200550: <http://trac.webkit.org/changeset/200550>
Comment 5 Chris Dumez 2016-05-07 21:38:36 PDT 
All reviewed patches have been landed.  Closing bug.