RESOLVED FIXED 157454
Reduce special handling of XPathNSResolver type in the bindings 
https://bugs.webkit.org/show_bug.cgi?id=157454
Summary Reduce special handling of XPathNSResolver type in the bindings
Chris Dumez
Reported 2016-05-07 15:02:53 PDT
Reduce special handling of XPathNSResolver type in the bindings
Attachments
Patch (53.56 KB, patch)
2016-05-07 20:28 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-05-07 20:28:09 PDT
Created attachment 278349 [details] Patch
Darin Adler
Comment 2 2016-05-07 21:34:43 PDT
Comment on attachment 278349 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278349&action=review > Source/WebCore/xml/XPathParser.h:75 > + RefPtr<XPathNSResolver> m_resolver; Is this safe? No reference cycles or anything?
Chris Dumez
Comment 3 2016-05-07 21:37:09 PDT
(In reply to comment #2) > Comment on attachment 278349 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=278349&action=review > > > Source/WebCore/xml/XPathParser.h:75 > > + RefPtr<XPathNSResolver> m_resolver; > > Is this safe? No reference cycles or anything? Yes, looks safe to me. XPath::Parser is only used as a local variable in Parser::parseStatement(). XPathNSResolver holds no reference to the Parser.
Chris Dumez
Comment 4 2016-05-07 21:38:30 PDT
Comment on attachment 278349 [details] Patch Clearing flags on attachment: 278349 Committed r200550: <http://trac.webkit.org/changeset/200550>
Chris Dumez
Comment 5 2016-05-07 21:38:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.