When a selected range contains a shadow host, we should be serializing the composed tree so that the user can copy & paste contents. <rdar://problem/24944602>
Created attachment 351175 [details] WIP
Created attachment 351207 [details] WIP2
Created attachment 351225 [details] WIP3
Pretty much done with adding the support for copying plain text and HTML.
Created attachment 351360 [details] Adds the support
Attachment 351360 [details] did not pass style-queue: ERROR: Source/WebCore/editing/markup.cpp:340: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource228.cpp:2: ./editing/TextIterator.cpp:349:5: error: use of undeclared identifier 'ASSSERT' ASSSERT(comparePositions(start, end) <= 0); ^ 1 error generated.
Created attachment 351428 [details] Fixed a typo
Attachment 351428 [details] did not pass style-queue: ERROR: Source/WebCore/editing/markup.cpp:340: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 351459 [details] Fixed GTK+ build
Attachment 351459 [details] did not pass style-queue: ERROR: Source/WebCore/editing/markup.cpp:340: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 351459 [details] Fixed GTK+ build View in context: https://bugs.webkit.org/attachment.cgi?id=351459&action=review > Source/WebCore/editing/markup.cpp:633 > + for (Node* n = startNode; n != pastEnd; lastNode = n, n = next) { auto*? > Source/WebCore/editing/markup.cpp:833 > + Node* nodeA = commonScope->ancestorNodeInThisScope(a.containerNode()); auto*
Comment on attachment 351459 [details] Fixed GTK+ build Attachment 351459 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9434856 New failing tests: editing/pasteboard/copy-paste-across-shadow-boundaries-3.html editing/pasteboard/copy-paste-across-shadow-boundaries-4.html editing/pasteboard/copy-paste-across-shadow-boundaries-2.html editing/pasteboard/copy-paste-across-shadow-boundaries-with-style-1.html editing/pasteboard/copy-paste-with-shadow-content.html
Created attachment 351471 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Sigh... -webkit-text-size-adjust: auto strikes again :( Will add iOS specific results.
Thanks for the review! (In reply to Wenson Hsieh from comment #12) > Comment on attachment 351459 [details] > Fixed GTK+ build > > View in context: > https://bugs.webkit.org/attachment.cgi?id=351459&action=review > > > Source/WebCore/editing/markup.cpp:633 > > + for (Node* n = startNode; n != pastEnd; lastNode = n, n = next) { > > auto*? Fixed. > > Source/WebCore/editing/markup.cpp:833 > > + Node* nodeA = commonScope->ancestorNodeInThisScope(a.containerNode()); > > auto* Fixed.
Created attachment 351476 [details] Patch for landing
Attachment 351476 [details] did not pass style-queue: ERROR: Source/WebCore/editing/markup.cpp:340: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r236785: <https://trac.webkit.org/changeset/236785>