Bug 157441 - [iOS WK2] Font size increases on some pages after navigating then going back
Summary: [iOS WK2] Font size increases on some pages after navigating then going back
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-06 18:31 PDT by Simon Fraser (smfr)
Modified: 2016-05-11 15:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (12.33 KB, patch)
2016-05-06 18:35 PDT, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-05-06 18:31:37 PDT 
[iOS WK2] Font size increases on some pages after navigating then going back
Comment 1 Simon Fraser (smfr) 2016-05-06 18:35:43 PDT 
Created attachment 278302 [details]
Patch
Comment 2 Darin Adler 2016-05-07 12:36:29 PDT 
Comment on attachment 278302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278302&action=review

> Source/WebCore/ChangeLog:9
> +        Sometimes I want to dump ViewportConfigurations from WebKit2 so export dump().

Seems like we’d want to export all or most of these “debug only for calling from the debugger” functions, not just this one.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2652
> -    setFixedLayoutSize(newLayoutSize);
> +    if (setFixedLayoutSize(newLayoutSize))
> +        resetTextAutosizing();

Should we build this behavior into the setFixedLayoutSize function instead of changing all call sites, or is there a valuable separation of responsibilities here?
Comment 3 Simon Fraser (smfr) 2016-05-09 14:16:30 PDT 
http://trac.webkit.org/changeset/200588

rdar://problem/22873240