Bug 15744 - Added FunctionCallResolveNode, PostfixResolveNode, and DeleteResolveNode to the AST transform
Summary: Added FunctionCallResolveNode, PostfixResolveNode, and DeleteResolveNode to t...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Geoffrey Garen
Depends on:
Blocks: 14868
  Show dependency treegraph
Reported: 2007-10-28 21:34 PDT by Geoffrey Garen
Modified: 2007-10-28 22:43 PDT (History)
0 users

See Also:

Patch (12.49 KB, patch)
2007-10-28 21:34 PDT, Geoffrey Garen
darin: review-
Details | Formatted Diff | Diff
Patch2 (13.32 KB, patch)
2007-10-28 22:24 PDT, Geoffrey Garen
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2007-10-28 21:34:35 PDT
Subtask of bug 14868.
Comment 1 Geoffrey Garen 2007-10-28 21:34:57 PDT
Created attachment 16931 [details]
Comment 2 Darin Adler 2007-10-28 22:03:09 PDT
Comment on attachment 16931 [details]

+JSValue* LocalVarDeleteNode::evaluate(ExecState* exec)

Unused parameter. Will warn when you merge with my settings.

+        , ident(ident)
+        , args(args.release())

These should both pass PlacementNewAdopt. See my recent patch for details.

Otherwise great!
Comment 3 Geoffrey Garen 2007-10-28 22:24:49 PDT
Created attachment 16932 [details]

Factored ASSERT code out into canSkipLookup. Removed unused parameter.
Comment 4 Geoffrey Garen 2007-10-28 22:25:06 PDT
Also used the right initializers.
Comment 5 Darin Adler 2007-10-28 22:31:31 PDT
Comment on attachment 16932 [details]

I'm worried about warnings in release builds due to the unused function.

Comment 6 Geoffrey Garen 2007-10-28 22:43:43 PDT
Committed revision 27210, with an #if !ASSERT_DISABLED.