Bug 157434 - Add WKPageRef SPI to tell whether there's a video playing in enhanced fullscreen
Summary: Add WKPageRef SPI to tell whether there's a video playing in enhanced fullscreen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-06 16:10 PDT by Ada Chan
Modified: 2016-06-05 12:43 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.21 KB, patch)
2016-05-06 16:31 PDT, Ada Chan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (919.69 KB, application/zip)
2016-05-06 17:06 PDT, Build Bot
no flags Details
Patch (5.27 KB, patch)
2016-05-06 22:23 PDT, Ada Chan
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2016-05-06 16:10:49 PDT
Adding this to WKPagePrivateMac.h:

WK_EXPORT bool WKPageIsPlayingVideoInEnhancedFullscreen(WKPageRef page);

Needed for <rdar://problem/24592796>
Comment 1 Ada Chan 2016-05-06 16:31:52 PDT
Created attachment 278288 [details]
Patch
Comment 2 Build Bot 2016-05-06 17:06:44 PDT
Comment on attachment 278288 [details]
Patch

Attachment 278288 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1279090

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2016-05-06 17:06:47 PDT
Created attachment 278293 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Ada Chan 2016-05-06 22:23:03 PDT
Created attachment 278319 [details]
Patch
Comment 5 Darin Adler 2016-05-07 12:28:25 PDT
Comment on attachment 278319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278319&action=review

> Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h:62
> +#if !TARGET_OS_IPHONE

I think that #if TARGET_OS_MAC might be more forward looking that specifically assuming that all !IPHONE will have this enhanced fullscreen thing.

> Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.mm:132
> +#if !TARGET_OS_IPHONE

Here in the .mm file we can and should use #if PLATFORM(MAC) instead.
Comment 6 Ada Chan 2016-05-09 14:33:12 PDT
Comment on attachment 278319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278319&action=review

Thanks for the review!

>> Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h:62
>> +#if !TARGET_OS_IPHONE
> 
> I think that #if TARGET_OS_MAC might be more forward looking that specifically assuming that all !IPHONE will have this enhanced fullscreen thing.

Changed to use #if TARGET_OS_MAC.

>> Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.mm:132
>> +#if !TARGET_OS_IPHONE
> 
> Here in the .mm file we can and should use #if PLATFORM(MAC) instead.

Changed to use #if PLATFORM(MAC)
Comment 7 Ada Chan 2016-06-05 12:43:48 PDT
Committed:
http://trac.webkit.org/changeset/200592