Bug 157432 - Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
Summary: Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-06 14:14 PDT by Simon Fraser (smfr)
Modified: 2016-05-06 17:05 PDT (History)
18 users (show)

See Also:


Attachments
Patch (60.68 KB, patch)
2016-05-06 14:27 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (60.53 KB, patch)
2016-05-06 14:33 PDT, Simon Fraser (smfr)
dino: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (1.18 MB, application/zip)
2016-05-06 15:32 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (1.53 MB, application/zip)
2016-05-06 15:38 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.32 MB, application/zip)
2016-05-06 15:39 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews116 for mac-yosemite (1.81 MB, application/zip)
2016-05-06 15:46 PDT, Build Bot
no flags Details
For EWS (60.33 KB, patch)
2016-05-06 15:57 PDT, Simon Fraser (smfr)
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.42 MB, application/zip)
2016-05-06 17:04 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (1.53 MB, application/zip)
2016-05-06 17:04 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-05-06 14:14:39 PDT
Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
Comment 1 Simon Fraser (smfr) 2016-05-06 14:27:50 PDT
Created attachment 278269 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-05-06 14:28:10 PDT
rdar://problem/16406720
Comment 3 Simon Fraser (smfr) 2016-05-06 14:33:34 PDT
Created attachment 278270 [details]
Patch
Comment 4 Dean Jackson 2016-05-06 15:13:50 PDT
Comment on attachment 278270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278270&action=review

r=me assuming gtk and efl are ok.

> Source/WebCore/dom/Document.cpp:5286
> +    LOG(TextAutosizing, " addAutoSizingNode %p candidateSize=%f", node, candidateSize);

Nit: you have a space at the start of the string

> Source/WebCore/page/FrameView.cpp:1413
> +            if (frame().settings().textAutosizingEnabled() && minimumZoomFontSize && textAutosizingWidth && !root->view().printing()) {

I didn't look at the entire function, but can't you put this frame().settings().textAutosizingEnabled() test right at the top under the #if ENABLE and skip everything if it is disabled?

> Source/WebCore/rendering/TextAutoSizing.cpp:121
> +            LOG(TextAutosizing, "  adjust node size %p firstPass=%d averageSize=%f scaleChange=%f", autoSizingNode.get(), firstPass, averageSize, scaleChange);

Starts with two spaces! Now I wonder if this is intentional.
Comment 5 Build Bot 2016-05-06 15:32:28 PDT
Comment on attachment 278270 [details]
Patch

Attachment 278270 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1278724

New failing tests:
fast/css/line-height-text-autosizing.html
fast/text-autosizing/ios/autosize-width.html
Comment 6 Build Bot 2016-05-06 15:32:35 PDT
Created attachment 278279 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-05-06 15:38:52 PDT
Comment on attachment 278270 [details]
Patch

Attachment 278270 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1278727

New failing tests:
fast/text-autosizing/ios/autosize-width.html
Comment 8 Build Bot 2016-05-06 15:38:58 PDT
Created attachment 278280 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 9 Build Bot 2016-05-06 15:39:46 PDT
Comment on attachment 278270 [details]
Patch

Attachment 278270 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1278726

New failing tests:
fast/css/line-height-text-autosizing.html
fast/text-autosizing/ios/autosize-width.html
Comment 10 Build Bot 2016-05-06 15:39:53 PDT
Created attachment 278281 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 11 Build Bot 2016-05-06 15:46:40 PDT
Comment on attachment 278270 [details]
Patch

Attachment 278270 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1278732

New failing tests:
fast/css/line-height-text-autosizing.html
fast/text-autosizing/ios/autosize-width.html
Comment 12 Build Bot 2016-05-06 15:46:47 PDT
Created attachment 278284 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 13 Simon Fraser (smfr) 2016-05-06 15:57:25 PDT
Created attachment 278286 [details]
For EWS
Comment 14 Build Bot 2016-05-06 17:04:05 PDT
Comment on attachment 278286 [details]
For EWS

Attachment 278286 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1279004

New failing tests:
fast/css/line-height-text-autosizing.html
fast/text-autosizing/ios/autosize-width.html
Comment 15 Build Bot 2016-05-06 17:04:10 PDT
Created attachment 278291 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 16 Build Bot 2016-05-06 17:04:30 PDT
Comment on attachment 278286 [details]
For EWS

Attachment 278286 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1279011

New failing tests:
fast/text-autosizing/ios/autosize-width.html
Comment 17 Build Bot 2016-05-06 17:04:35 PDT
Created attachment 278292 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 18 Simon Fraser (smfr) 2016-05-06 17:05:57 PDT
https://trac.webkit.org/r200534