Bug 157432 – Enable IOS_TEXT_AUTOSIZING on Mac and make it testable

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Enable IOS_TEXT_AUTOSIZING on Mac and make it testable

[Simon Fraser (smfr)]

Created attachment 278269 [details]
Patch

[Simon Fraser (smfr)]

rdar://problem/16406720

[Simon Fraser (smfr)]

Created attachment 278270 [details]
Patch

[Dean Jackson]

Comment on attachment 278270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278270&action=review

r=me assuming gtk and efl are ok.

> Source/WebCore/dom/Document.cpp:5286
> +    LOG(TextAutosizing, " addAutoSizingNode %p candidateSize=%f", node, candidateSize);

Nit: you have a space at the start of the string

> Source/WebCore/page/FrameView.cpp:1413
> +            if (frame().settings().textAutosizingEnabled() && minimumZoomFontSize && textAutosizingWidth && !root->view().printing()) {

I didn't look at the entire function, but can't you put this frame().settings().textAutosizingEnabled() test right at the top under the #if ENABLE and skip everything if it is disabled?

> Source/WebCore/rendering/TextAutoSizing.cpp:121
> +            LOG(TextAutosizing, "  adjust node size %p firstPass=%d averageSize=%f scaleChange=%f", autoSizingNode.get(), firstPass, averageSize, scaleChange);

Starts with two spaces! Now I wonder if this is intentional.

[Build Bot]

Comment on attachment 278270 [details]
Patch

Attachment 278270 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1278724

New failing tests:
fast/css/line-height-text-autosizing.html
fast/text-autosizing/ios/autosize-width.html

[Build Bot]

Created attachment 278279 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278270 [details]
Patch

Attachment 278270 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1278727

New failing tests:
fast/text-autosizing/ios/autosize-width.html

[Build Bot]

Created attachment 278280 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Build Bot]

Comment on attachment 278270 [details]
Patch

Attachment 278270 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1278726

New failing tests:
fast/css/line-height-text-autosizing.html
fast/text-autosizing/ios/autosize-width.html

[Build Bot]

Created attachment 278281 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278270 [details]
Patch

Attachment 278270 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1278732

New failing tests:
fast/css/line-height-text-autosizing.html
fast/text-autosizing/ios/autosize-width.html

[Build Bot]

Created attachment 278284 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Simon Fraser (smfr)]

Created attachment 278286 [details]
For EWS

[Build Bot]

Comment on attachment 278286 [details]
For EWS

Attachment 278286 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1279004

New failing tests:
fast/css/line-height-text-autosizing.html
fast/text-autosizing/ios/autosize-width.html

[Build Bot]

Created attachment 278291 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278286 [details]
For EWS

Attachment 278286 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1279011

New failing tests:
fast/text-autosizing/ios/autosize-width.html

[Build Bot]

Created attachment 278292 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Simon Fraser (smfr)]

https://trac.webkit.org/r200534