Web Inspector: Unexpected white border at the bottom of Debugger filter bar

[Nikita Vasilyev]

Created attachment 278264 [details]
[Image] Bug

This is caused by:

.navigation-bar {
    box-shadow: inset hsla(0, 0%, 100%, 0.2) 0 1px 0;
}

I'm not sure what's the point of it.
`git blame` tells me the first version of NavigationBar.css
already had it.

[Radar WebKit Bug Importer]

<rdar://problem/26146602>

[Nikita Vasilyev]

Created attachment 278267 [details]
[Image] Semi-transparent white box shadow replaced with red

In the Timelines these inset box shadows are
either bugs (e.g. under "Details") or have no
effect (white on white).

[Nikita Vasilyev]

(In reply to comment #2)
> Created attachment 278267 [details]
> [Image] Semi-transparent white box shadow replaced with red

To clarify, I replaced 

    box-shadow: inset hsla(0, 0%, 100%, 0.2) 0 1px 0;

with

    box-shadow: inset red 0 1px 0;

purely for debugging purposes.

[Timothy Hatcher]

We can drop it. It was more important when we didn't have a flat UI. This should have been removed when we made that change.

[Nikita Vasilyev]

Created attachment 278272 [details]
Patch

[Timothy Hatcher]

Comment on attachment 278272 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278272&action=review

> Source/WebInspectorUI/ChangeLog:10
> +        Remove the semi-transparent white border for all navigation bars
> +        except for the split console.

I think we can remove it from the split console too.

[Timothy Hatcher]

Comment on attachment 278272 [details]
Patch

We should remove from SearchSidebarPanel.css too.

[Nikita Vasilyev]

Created attachment 278275 [details]
Patch

[Nikita Vasilyev]

Created attachment 278276 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 278276 [details]
Patch

Clearing flags on attachment: 278276

Committed r200529: <http://trac.webkit.org/changeset/200529>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.