RESOLVED FIXED157430
Web Inspector: Unexpected white border at the bottom of Debugger filter bar 
https://bugs.webkit.org/show_bug.cgi?id=157430
Summary Web Inspector: Unexpected white border at the bottom of Debugger filter bar
Nikita Vasilyev
Reported 2016-05-06 13:26:28 PDT
Created attachment 278264 [details] [Image] Bug This is caused by: .navigation-bar { box-shadow: inset hsla(0, 0%, 100%, 0.2) 0 1px 0; } I'm not sure what's the point of it. `git blame` tells me the first version of NavigationBar.css already had it.
Attachments
[Image] Bug (36.33 KB, image/png)
2016-05-06 13:26 PDT, Nikita Vasilyev 		no flags
Details
[Image] Semi-transparent white box shadow replaced with red (80.98 KB, image/png)
2016-05-06 14:13 PDT, Nikita Vasilyev 		no flags
Details
Patch (1.95 KB, patch)
2016-05-06 14:52 PDT, Nikita Vasilyev 		timothy: review+
DetailsFormatted DiffDiff
Patch (1.25 KB, patch)
2016-05-06 15:02 PDT, Nikita Vasilyev 		nvasilyev: commit-queue-
DetailsFormatted DiffDiff
Patch (1.77 KB, patch)
2016-05-06 15:09 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-05-06 13:27:00 PDT
<rdar://problem/26146602>
Nikita Vasilyev
Comment 2 2016-05-06 14:13:07 PDT
Created attachment 278267 [details] [Image] Semi-transparent white box shadow replaced with red In the Timelines these inset box shadows are either bugs (e.g. under "Details") or have no effect (white on white).
Nikita Vasilyev
Comment 3 2016-05-06 14:14:27 PDT
(In reply to comment #2) > Created attachment 278267 [details] > [Image] Semi-transparent white box shadow replaced with red To clarify, I replaced box-shadow: inset hsla(0, 0%, 100%, 0.2) 0 1px 0; with box-shadow: inset red 0 1px 0; purely for debugging purposes.
Timothy Hatcher
Comment 4 2016-05-06 14:37:42 PDT
We can drop it. It was more important when we didn't have a flat UI. This should have been removed when we made that change.
Nikita Vasilyev
Comment 5 2016-05-06 14:52:51 PDT
Created attachment 278272 [details] Patch
Timothy Hatcher
Comment 6 2016-05-06 14:56:53 PDT
Comment on attachment 278272 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278272&action=review > Source/WebInspectorUI/ChangeLog:10 > + Remove the semi-transparent white border for all navigation bars > + except for the split console. I think we can remove it from the split console too.
Timothy Hatcher
Comment 7 2016-05-06 14:58:35 PDT
Comment on attachment 278272 [details] Patch We should remove from SearchSidebarPanel.css too.
Nikita Vasilyev
Comment 8 2016-05-06 15:02:33 PDT
Created attachment 278275 [details] Patch
Nikita Vasilyev
Comment 9 2016-05-06 15:09:06 PDT
Created attachment 278276 [details] Patch
WebKit Commit Bot
Comment 10 2016-05-06 15:38:25 PDT
Comment on attachment 278276 [details] Patch Clearing flags on attachment: 278276 Committed r200529: <http://trac.webkit.org/changeset/200529>
WebKit Commit Bot
Comment 11 2016-05-06 15:38:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.