Bug 157428 - Add JSC options bytecodeRangeToJITCompile and jitWhitelist.
Summary: Add JSC options bytecodeRangeToJITCompile and jitWhitelist.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-06 13:17 PDT by Mark Lam
Modified: 2016-05-07 09:20 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch (32.50 KB, patch)
2016-05-06 17:03 PDT, Mark Lam 		msaboff: review-
Details | Formatted Diff | Diff
proposed patch with Michael's feedback. (32.41 KB, patch)
2016-05-06 18:54 PDT, Mark Lam 		msaboff: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-05-06 13:17:04 PDT 
... because this is useful for baseline JIT debugging too.
Comment 1 Mark Lam 2016-05-06 17:03:31 PDT 
Created attachment 278290 [details]
proposed patch
Comment 2 Michael Saboff 2016-05-06 17:11:09 PDT 
Comment on attachment 278290 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278290&action=review

r-
Please make the suggested changes.

> Source/JavaScriptCore/ChangeLog:35
> +        * jit/JITFunctionWhitelist.cpp: Copied from Source/JavaScriptCore/dfg/DFGFunctionWhitelist.cpp.
> +        (JSC::JITFunctionWhitelist::ensureGlobalBaselineWhitelist):
> +        (JSC::JITFunctionWhitelist::ensureGlobalDFGWhitelist):
> +        (JSC::JITFunctionWhitelist::JITFunctionWhitelist):
> +        (JSC::JITFunctionWhitelist::parseFunctionNamesInFile):
> +        (JSC::JITFunctionWhitelist::contains):
> +        (JSC::DFG::FunctionWhitelist::ensureGlobalWhitelist): Deleted.
> +        (JSC::DFG::FunctionWhitelist::FunctionWhitelist): Deleted.
> +        (JSC::DFG::FunctionWhitelist::parseFunctionNamesInFile): Deleted.
> +        (JSC::DFG::FunctionWhitelist::contains): Deleted.
> +        * jit/JITFunctionWhitelist.h: Copied from Source/JavaScriptCore/dfg/DFGFunctionWhitelist.h.

Make this a generic FunctionWhiteList class.

> Source/JavaScriptCore/runtime/Options.h:148
> +    v(optionRange, bytecodeRangeToBaselineCompile, 0, Normal, "bytecode size range to allow Baseline JIT compilation on, e.g. 1:100") \

Let's call this "bytecodeRangeToJITCompile".

> Source/JavaScriptCore/runtime/Options.h:151
> +    v(optionString, baselineWhitelist, nullptr, Normal, "file with list of function signatures to allow Baseline JIT compilation on") \

Let's call this "jitWhitelist"
Comment 3 Mark Lam 2016-05-06 18:54:45 PDT 
Created attachment 278308 [details]
proposed patch with Michael's feedback.
Comment 4 Michael Saboff 2016-05-07 07:40:41 PDT 
Comment on attachment 278308 [details]
proposed patch with Michael's feedback.

r=me
Comment 5 Mark Lam 2016-05-07 09:20:07 PDT 
Thanks for the review.  Landed in r200543: <http://trac.webkit.org/r200543>.