Bug 157425 - <attachment> element should understand UTIs
Summary: <attachment> element should understand UTIs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-06 13:06 PDT by Tim Horton
Modified: 2016-05-06 15:52 PDT (History)
6 users (show)

See Also:

Attachments
Patch (10.31 KB, patch)
2016-05-06 13:06 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (637.75 KB, application/zip)
2016-05-06 14:12 PDT, Build Bot 		no flags Details
Patch (10.29 KB, patch)
2016-05-06 14:15 PDT, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2016-05-06 13:06:01 PDT 
<attachment> element should understand UTIs
Comment 1 Tim Horton 2016-05-06 13:06:28 PDT 
Created attachment 278261 [details]
Patch
Comment 2 Tim Horton 2016-05-06 13:08:57 PDT 
<rdar://problem/25585401>
Comment 3 Build Bot 2016-05-06 14:12:22 PDT 
Comment on attachment 278261 [details]
Patch

Attachment 278261 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1278385

New failing tests:
fast/attachment/attachment-uti.html
Comment 4 Build Bot 2016-05-06 14:12:25 PDT 
Created attachment 278266 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 5 Tim Horton 2016-05-06 14:15:59 PDT 
Created attachment 278268 [details]
Patch
Comment 6 Anders Carlsson 2016-05-06 14:20:18 PDT 
Comment on attachment 278268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278268&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:1500
> +    RetainPtr<UIDocumentInteractionController> documentInteractionController = adoptNS([[getUIDocumentInteractionControllerClass() alloc] init]);

Use auto here.

> Source/WebCore/rendering/RenderThemeIOS.mm:1512
> +        RetainPtr<CFStringRef> attachmentTypeCF = attachmentType.createCFString();

Again, auto here.

> Source/WebCore/rendering/RenderThemeMac.mm:2414
> +            RetainPtr<CFStringRef> attachmentTypeCF = attachmentType.createCFString();

Use auto here.
Comment 7 Tim Horton 2016-05-06 15:52:12 PDT 
http://trac.webkit.org/changeset/200530