When getting string from text marker range, we should make sure <attachment> element gets a replacement character. <rdar://problem/25297609>
<rdar://problem/26132136>
Created attachment 278221 [details] patch <attachment> is being ignored in Safari so not sure how to write a test to verify the replacement character. Did test with Mac Mail and it was working.
Comment on attachment 278221 [details] patch Attachment 278221 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1274450 New failing tests: editing/pasteboard/drag-and-drop-attachment-contenteditable.html accessibility/attachment-element.html
Created attachment 278223 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 278221 [details] patch Attachment 278221 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1274513 New failing tests: accessibility/attachment-element.html
Created attachment 278226 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Seems this is affecting other stuff. I'll try to make the changes in accessibility code.
Comment on attachment 278221 [details] patch Attachment 278221 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1274519 New failing tests: editing/pasteboard/drag-and-drop-attachment-contenteditable.html accessibility/attachment-element.html
Created attachment 278227 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 278221 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=278221&action=review > Source/WebCore/ChangeLog:9 > + in the attachment layout test in accessibility you'll see a way to enable attachment element through an internals call
Created attachment 278241 [details] patch Fixed up build and added a layout test.
Comment on attachment 278241 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=278241&action=review > Source/WebCore/editing/TextIterator.cpp:258 > + if (renderer->isImage() || renderer->isWidget() || renderer->isMedia() || renderer->isAttachment()) I would also do this like bool isAttachment = false; #if ENABLE() isAttachment = renderer->... #endif if (renderer... so that we don't have to duplicate the logic checks
Comment on attachment 278241 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=278241&action=review >> Source/WebCore/editing/TextIterator.cpp:258 >> + if (renderer->isImage() || renderer->isWidget() || renderer->isMedia() || renderer->isAttachment()) > > I would also do this like > bool isAttachment = false; > #if ENABLE() > isAttachment = renderer->... > #endif > > if (renderer... > > so that we don't have to duplicate the logic checks Ok, will make the change before committing.
Committed r200509: <http://trac.webkit.org/changeset/200509>