Bug 157390 - Add WebKitAdditions extension points in media controls related code in RenderThemeMac
Summary: Add WebKitAdditions extension points in media controls related code in Render...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-05 14:34 PDT by Ada Chan
Modified: 2016-05-05 16:31 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.87 KB, patch)
2016-05-05 15:11 PDT, Ada Chan 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2016-05-05 14:34:52 PDT 
Add WebKitAdditions extension points in media controls related code in RenderThemeMac.

For <rdar://problem/25837401>
Comment 1 Ada Chan 2016-05-05 15:11:04 PDT 
Created attachment 278195 [details]
Patch
Comment 2 Anders Carlsson 2016-05-05 16:09:16 PDT 
Comment on attachment 278195 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278195&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:238
> +#if USE(APPLE_INTERNAL_SDK)
> +#import <WebKitAdditions/RenderThemeMacMediaControlsStyleSheetAdditions.mm>
> +#endif

I'd put newlines before and after this to make it look less crowded.

> Source/WebCore/rendering/RenderThemeMac.mm:256
> +#if USE(APPLE_INTERNAL_SDK)
> +#import <WebKitAdditions/RenderThemeMacMediaControlsScriptAdditions.mm>
> +#endif

Same here!
Comment 3 Ada Chan 2016-05-05 16:31:40 PDT 
(In reply to comment #2)
> Comment on attachment 278195 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=278195&action=review
> 
> > Source/WebCore/rendering/RenderThemeMac.mm:238
> > +#if USE(APPLE_INTERNAL_SDK)
> > +#import <WebKitAdditions/RenderThemeMacMediaControlsStyleSheetAdditions.mm>
> > +#endif
> 
> I'd put newlines before and after this to make it look less crowded.
> 
> > Source/WebCore/rendering/RenderThemeMac.mm:256
> > +#if USE(APPLE_INTERNAL_SDK)
> > +#import <WebKitAdditions/RenderThemeMacMediaControlsScriptAdditions.mm>
> > +#endif
> 
> Same here!

Newlines added.

Thanks for the review!

Committed:
http://trac.webkit.org/changeset/200491