PageOverlay's destructor should call WebPageOverlay::pageOverlayDestroyed() and WebPageOverlay::pageOverlayDestroyed() should remove the PageOverlay from its hash map.
Created attachment 278191 [details]
Comment on attachment 278191 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=278191&action=review
> + Now revoes the given PageOverlay from its overlay HashMap.
> - m_client->pageOverlayDestroyed(*this);
Why did you stop calling WebPageOverlay::Client's pageOverlayDestroyed callback? Seems like you're introducing a new version of the same bug you're fixing at a different level :) (or perhaps just leaking API::PageOverlayClientImpl?)
Changed the title to reflect what we intend to do.
Created attachment 278212 [details]
Comment on attachment 278212 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=278212&action=review
You should explain what's happening:
"Remove dead PageOverlay code. All uses of the WebPageOverlay are handled through unique pointers that automatically deleted when the
WebPageOverlay object itself is deleted. Thus, there is no need to call pageOverlayDestroyed as objects are guaranteed to be completely
... or something along those lines.
Created attachment 278254 [details]
Comment on attachment 278254 [details]
Clearing flags on attachment: 278254
Committed r201224: <http://trac.webkit.org/changeset/201224>
All reviewed patches have been landed. Closing bug.