Bug 157388 – Remove unnecessary PageOverlay client function pageOverlayDestroyed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[John Wilander]

PageOverlay's destructor should call WebPageOverlay::pageOverlayDestroyed() and WebPageOverlay::pageOverlayDestroyed() should remove the PageOverlay from its hash map.

[John Wilander]

rdar://problem/25471523

[John Wilander]

Created attachment 278191 [details]
Patch

[Tim Horton]

Comment on attachment 278191 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278191&action=review

> Source/WebKit2/ChangeLog:11
> +            Now revoes the given PageOverlay from its overlay HashMap.

revoes?

> Source/WebKit2/WebProcess/WebPage/WebPageOverlay.cpp:-94
> -    m_client->pageOverlayDestroyed(*this);

Why did you stop calling WebPageOverlay::Client's pageOverlayDestroyed callback? Seems like you're introducing a new version of the same bug you're fixing at a different level :) (or perhaps just leaking API::PageOverlayClientImpl?)

[John Wilander]

Changed the title to reflect what we intend to do.

[John Wilander]

Created attachment 278212 [details]
Patch

[Brent Fulgham]

Comment on attachment 278212 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278212&action=review

> Source/WebCore/ChangeLog:8
> +

You should explain what's happening:

"Remove dead PageOverlay code. All uses of the WebPageOverlay are handled through unique pointers that automatically deleted when the
WebPageOverlay object itself is deleted. Thus, there is no need to call pageOverlayDestroyed as objects are guaranteed to be completely
cleaned up."

... or something along those lines.

[John Wilander]

Created attachment 278254 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 278254 [details]
Patch

Clearing flags on attachment: 278254

Committed r201224: <http://trac.webkit.org/changeset/201224>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.