Bug 157387 - JSContext Inspector: Better CommandLineAPI in JSContext inspection
Summary: JSContext Inspector: Better CommandLineAPI in JSContext inspection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-05 14:11 PDT by Joseph Pecoraro
Modified: 2016-05-05 15:11 PDT (History)
12 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (3.94 KB, patch)
2016-05-05 14:13 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (3.75 KB, patch)
2016-05-05 14:19 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-05 14:11:01 PDT
* SUMMARY
Better CommandLineAPI in JSContext inspection.

* NOTES
Much of the command line API doesn't apply to JSContexts, but some of it does and can be implemented:

    dir, clear, table, profile, profileEnd, keys, values

The only thing this is really lacking is `copy(...)`.
Comment 1 Joseph Pecoraro 2016-05-05 14:11:07 PDT
<rdar://problem/22630583>
Comment 2 Joseph Pecoraro 2016-05-05 14:13:32 PDT
Created attachment 278187 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2016-05-05 14:18:10 PDT
Comment on attachment 278187 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=278187&action=review

> Source/JavaScriptCore/inspector/InjectedScriptSource.js:1439
> +    inspectedGlobalObject.console.warn("Before");

Hahah, I should not have these debug statements.
Comment 4 Joseph Pecoraro 2016-05-05 14:19:00 PDT
Created attachment 278188 [details]
[PATCH] Proposed Fix
Comment 5 WebKit Commit Bot 2016-05-05 15:11:20 PDT
Comment on attachment 278188 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 278188

Committed r200482: <http://trac.webkit.org/changeset/200482>
Comment 6 WebKit Commit Bot 2016-05-05 15:11:23 PDT
All reviewed patches have been landed.  Closing bug.