Bug 157371 – Web Inspector: HeapSnapshot should exploratory Object Graph view

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
HeapSnapshot should exploratory Object Graph view

Should be able to explore the Heap. A good starting point are the global objects themselves. This avoids complexity around things the VM references directly (Conservative Roots, JSGlobalObject structures, small strings, DOMWrapperWorld references, etc) but its still understandable to users:

• JSContext Inspector - show the Global Object
• Web Inspector - show the Window objects

[Joseph Pecoraro]

Created attachment 278157 [details]
[IMAGE] JSContext GlobalObject Object Graph

[Joseph Pecoraro]

Created attachment 278158 [details]
[IMAGE] Web Page Windows List

Since the Object Preview was mostly useless on windows, I changed the preview to compute the `window.location.href` for the window object. That tends to be much more useful for pages with lots and lots of frames. But we still might need to make this stronger.

[Radar WebKit Bug Importer]

<rdar://problem/26107304>

[Joseph Pecoraro]

Created attachment 278159 [details]
[PATCH] Work In Progress - Needs More Testing

This basically shares all the code. The Object Graph view just shows the 
"Window" || "GlobalObject" instances at the top level, and when expanding we always show the retained size.

I want to test it more tomorrow:
- Window objects seem to be kept alive across navigations making the graph output poor
- Is window.location.href enough? That screenshot is kinda heavy, but that page is heavy.

[Joseph Pecoraro]

Comment on attachment 278159 [details]
[PATCH] Work In Progress - Needs More Testing

View in context: https://bugs.webkit.org/attachment.cgi?id=278159&action=review

> Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstancesContentView.css:-54
> -.heap-snapshot > .data-grid tr:not(.selected) td .preview-error {
> -    color: red;
> -}

The "Internal Object" and "Preview Not Available" messages were standing out way too much. This makes them black text, much easier on the eyes.

[Joseph Pecoraro]

Created attachment 278179 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 278179 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 278179

Committed r200474: <http://trac.webkit.org/changeset/200474>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Simon Fraser (smfr)]

should exploratory?

[Joseph Pecoraro]

(In reply to comment #9)
> should exploratory?

=(. *should have*.

[Joseph Pecoraro]

Comment on attachment 278179 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=278179&action=review

> Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:189
>                  WebInspector.runtimeManager.evaluateInInspectedWindow("(" + getCompletions + ")(\"" + result.type + "\")", "completion", false, true, true, false, false, receivedPropertyNamesFromEvaluate.bind(this));

Missed renaming this `getCompletions` =(