Bug 157369 - event.target shouldn't be retargeted as the event bubbles into a slot
Summary: event.target shouldn't be retargeted as the event bubbles into a slot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 148695
  Show dependency treegraph
 
Reported: 2016-05-04 20:22 PDT by Ryosuke Niwa
Modified: 2016-05-05 14:32 PDT (History)
6 users (show)

See Also:


Attachments
Fixes the bug (28.01 KB, patch)
2016-05-04 21:03 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (27.98 KB, patch)
2016-05-05 09:16 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (28.58 KB, patch)
2016-05-05 09:42 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (28.58 KB, patch)
2016-05-05 10:05 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-05-04 20:22:28 PDT
When an event bubbles up from an assigned node to its assigned slot,
we shouldn't be adjusting event.target to point to the slot.

Since a shadow tree should have access to nodes outside the shadow tree,
event.target should be accessible inside the shadow tree of such a slot.
Comment 1 Ryosuke Niwa 2016-05-04 21:03:02 PDT
Created attachment 278154 [details]
Fixes the bug
Comment 2 Antti Koivisto 2016-05-05 05:32:27 PDT
Comment on attachment 278154 [details]
Fixes the bug

r=me, nice that this behavior change simplifies the logic.
Comment 3 Antti Koivisto 2016-05-05 05:33:28 PDT
Please fix build with shadow DOM disabled before landing.
Comment 4 Ryosuke Niwa 2016-05-05 09:16:18 PDT
Created attachment 278167 [details]
Patch for landing
Comment 5 Ryosuke Niwa 2016-05-05 09:16:38 PDT
Comment on attachment 278167 [details]
Patch for landing

Wait for EWS.
Comment 6 Ryosuke Niwa 2016-05-05 09:42:17 PDT
Created attachment 278169 [details]
Patch for landing
Comment 7 Ryosuke Niwa 2016-05-05 10:05:47 PDT
Created attachment 278172 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2016-05-05 11:32:38 PDT
Comment on attachment 278172 [details]
Patch for landing

Clearing flags on attachment: 278172

Committed r200464: <http://trac.webkit.org/changeset/200464>
Comment 9 WebKit Commit Bot 2016-05-05 11:32:44 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2016-05-05 13:03:12 PDT
<rdar://problem/26123016>