Bug 157367 - Add HLE locks and synchronic TTAS locks to the ToyLocks benchmark suite
Summary: Add HLE locks and synchronic TTAS locks to the ToyLocks benchmark suite
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-04 17:13 PDT by Filip Pizlo
Modified: 2016-05-04 17:17 PDT (History)
1 user (show)

See Also:

Attachments
the patch (3.59 KB, patch)
2016-05-04 17:16 PDT, Filip Pizlo 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-05-04 17:13:32 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-05-04 17:16:01 PDT 
Created attachment 278145 [details]
the patch
Comment 2 WebKit Commit Bot 2016-05-04 17:17:26 PDT 
Attachment 278145 [details] did not pass style-queue:


ERROR: Source/WTF/benchmarks/ToyLocks.h:113:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:116:  Wrong number of spaces before statement. (expected: 20)  [whitespace/indent] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:117:  Wrong number of spaces before statement. (expected: 20)  [whitespace/indent] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:121:  Wrong number of spaces before statement. (expected: 20)  [whitespace/indent] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:125:  Wrong number of spaces before statement. (expected: 20)  [whitespace/indent] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:117:  Wrong number of spaces before statement. (expected: 20)  [whitespace/indent] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:121:  Wrong number of spaces before statement. (expected: 20)  [whitespace/indent] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:125:  Wrong number of spaces before statement. (expected: 20)  [whitespace/indent] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:127:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:130:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:134:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:130:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:134:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
Total errors found: 13 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2016-05-04 17:17:53 PDT 
Landed in http://trac.webkit.org/changeset/200444