Bug 157366 - [iOS] Playback does not pause when locking screen after playing to AirPlay.
Summary: [iOS] Playback does not pause when locking screen after playing to AirPlay.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-04 16:56 PDT by Eric Carlson
Modified: 2016-05-05 12:24 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch. (1.78 KB, patch)
2016-05-04 17:02 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2016-05-04 16:56:02 PDT 
Playback does not pause when locking screen after playing to AirPlay.
Comment 1 Eric Carlson 2016-05-04 17:01:02 PDT 
<rdar://problem/22100651>
Comment 2 Eric Carlson 2016-05-04 17:02:32 PDT 
Created attachment 278144 [details]
Proposed patch.
Comment 3 WebKit Commit Bot 2016-05-04 17:55:19 PDT 
Comment on attachment 278144 [details]
Proposed patch.

Clearing flags on attachment: 278144

Committed r200446: <http://trac.webkit.org/changeset/200446>
Comment 4 WebKit Commit Bot 2016-05-04 17:55:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Jeremy Jones 2016-05-05 12:24:08 PDT 
Comment on attachment 278144 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=278144&action=review

> Source/WebCore/platform/audio/PlatformMediaSession.cpp:294
> +    // if we in the background.

"because if we in the background" doesn't sound right maybe "while in the background".