Bug 157365 - Add a few more WTF locking benchmarks
Summary: Add a few more WTF locking benchmarks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-04 15:56 PDT by Filip Pizlo
Modified: 2016-05-04 16:01 PDT (History)
1 user (show)

See Also:

Attachments
the patch (34.50 KB, patch)
2016-05-04 15:58 PDT, Filip Pizlo 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-05-04 15:56:48 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-05-04 15:58:34 PDT 
Created attachment 278137 [details]
the patch
Comment 2 WebKit Commit Bot 2016-05-04 15:59:38 PDT 
Attachment 278137 [details] did not pass style-queue:


ERROR: Source/WTF/benchmarks/LockSpeedTest.cpp:95:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WTF/benchmarks/LockFairnessTest.cpp:74:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:35:  Do not use unnamed namespaces in header files.  See http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces for more information.  [build/namespaces] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:78:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/benchmarks/ToyLocks.h:157:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 5 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2016-05-04 16:01:02 PDT 
Landed in http://trac.webkit.org/changeset/200438