Bug 157363 - Experimental Features don't need an "Experimental" prefix
Summary: Experimental Features don't need an "Experimental" prefix
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
Keywords: InRadar
Depends on:
Reported: 2016-05-04 15:39 PDT by Dean Jackson
Modified: 2016-05-04 16:41 PDT (History)
1 user (show)

See Also:

Patch (6.16 KB, patch)
2016-05-04 15:41 PDT, Dean Jackson
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2016-05-04 15:39:26 PDT
Experimental Features don't need an "Experimental" prefix
Comment 1 Radar WebKit Bug Importer 2016-05-04 15:41:49 PDT
Comment 2 Dean Jackson 2016-05-04 15:41:59 PDT
Created attachment 278136 [details]
Comment 3 Anders Carlsson 2016-05-04 15:46:37 PDT
Comment on attachment 278136 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=278136&action=review

> Source/WebKit2/Shared/WebPreferencesDefinitions.h:296
> +    macro(cssGridLayoutEnabled, cssGridLayoutEnabled, Bool, bool, false, "CSS Grid", "CSS Grid Layout Module support") \
> +    macro(customElementsEnabled, customElementsEnabled, Bool, bool, false, "Custom Elements", "HTML Custom Elements prototype") \
> +    macro(shadowDOMEnabled, shadowDOMEnabled, Bool, bool, false, "Shadow DOM", "HTML Shadow DOM prototype") \
> +    macro(webGL2Enabled, webGL2Enabled, Bool, bool, false, "WebGL 2.0", "WebGL 2 prototype") \

Did you intend to make the keys lower case here?
Comment 4 Dean Jackson 2016-05-04 15:57:34 PDT
(In reply to comment #3)

> Did you intend to make the keys lower case here?

I did not. Thank you.
Comment 5 Dean Jackson 2016-05-04 16:41:57 PDT
Committed r200440: <http://trac.webkit.org/changeset/200440>