Bug 157352 - Disabling WebGL2 should mean no context is created
Summary: Disabling WebGL2 should mean no context is created
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-04 13:11 PDT by Dean Jackson
Modified: 2016-05-06 11:10 PDT (History)
8 users (show)

See Also:

Attachments
Patch (6.62 KB, patch)
2016-05-04 13:15 PDT, Dean Jackson 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2016-05-04 13:11:09 PDT 
When the runtime flag for WebGL2 is off, we should not create a context.
Comment 1 Radar WebKit Bug Importer 2016-05-04 13:12:27 PDT 
<rdar://problem/26096346>
Comment 2 Dean Jackson 2016-05-04 13:15:13 PDT 
Created attachment 278117 [details]
Patch
Comment 3 Dean Jackson 2016-05-04 15:29:44 PDT 
Committed r200435: <http://trac.webkit.org/changeset/200435>
Comment 4 Darin Adler 2016-05-06 11:10:18 PDT 
Comment on attachment 278117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278117&action=review

> Source/WebCore/testing/Internals.idl:459
> +#if defined(ENABLE_WEBGL2) && ENABLE_WEBGL2
> +    boolean webGL2Enabled();
> +    void setWebGL2Enabled(boolean enable);
> +#endif

Can we use [Conditional] instead of #if here?