WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
157352
Disabling WebGL2 should mean no context is created
https://bugs.webkit.org/show_bug.cgi?id=157352
Summary
Disabling WebGL2 should mean no context is created
Dean Jackson
Reported
2016-05-04 13:11:09 PDT
When the runtime flag for WebGL2 is off, we should not create a context.
Attachments
Patch
(6.62 KB, patch)
2016-05-04 13:15 PDT
,
Dean Jackson
eric.carlson
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2016-05-04 13:12:27 PDT
<
rdar://problem/26096346
>
Dean Jackson
Comment 2
2016-05-04 13:15:13 PDT
Created
attachment 278117
[details]
Patch
Dean Jackson
Comment 3
2016-05-04 15:29:44 PDT
Committed
r200435
: <
http://trac.webkit.org/changeset/200435
>
Darin Adler
Comment 4
2016-05-06 11:10:18 PDT
Comment on
attachment 278117
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=278117&action=review
> Source/WebCore/testing/Internals.idl:459 > +#if defined(ENABLE_WEBGL2) && ENABLE_WEBGL2 > + boolean webGL2Enabled(); > + void setWebGL2Enabled(boolean enable); > +#endif
Can we use [Conditional] instead of #if here?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug