Bug 157351 - Corrections to r200422
Summary: Corrections to r200422
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-04 12:15 PDT by Keith Miller
Modified: 2016-05-04 15:00 PDT (History)
6 users (show)

See Also:

Attachments
Patch (9.76 KB, patch)
2016-05-04 12:26 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-05-04 12:15:13 PDT 
Corrections to r200422
Comment 1 Keith Miller 2016-05-04 12:26:59 PDT 
Created attachment 278111 [details]
Patch
Comment 2 WebKit Commit Bot 2016-05-04 12:28:54 PDT 
This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)
Comment 3 Joseph Pecoraro 2016-05-04 13:11:47 PDT 
Comment on attachment 278111 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278111&action=review

r=me, thanks!

> Source/JavaScriptCore/ChangeLog:9
> +        for the this value being undefined vs null in the ArrayIteratorprototype

Typo: ArrayIteratorprototype => ArrayIteratorPrototype
Comment 4 WebKit Commit Bot 2016-05-04 13:48:50 PDT 
Comment on attachment 278111 [details]
Patch

Clearing flags on attachment: 278111

Committed r200428: <http://trac.webkit.org/changeset/200428>
Comment 5 WebKit Commit Bot 2016-05-04 13:48:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryan Haddad 2016-05-04 15:00:58 PDT 
It looks like this change some JSC test failures:

	stress/array-iterators-next-with-call.js.always-trigger-copy-phase
	stress/array-iterators-next-with-call.js.default
	stress/array-iterators-next-with-call.js.default-ftl
	stress/array-iterators-next-with-call.js.dfg-eager
	stress/array-iterators-next-with-call.js.dfg-eager-no-cjit-validate
	stress/array-iterators-next-with-call.js.dfg-maximal-flush-validate-no-cjit
	stress/array-iterators-next-with-call.js.ftl-eager
	stress/array-iterators-next-with-call.js.ftl-eager-no-cjit
	stress/array-iterators-next-with-call.js.ftl-no-cjit-no-inline-validate
	stress/array-iterators-next-with-call.js.ftl-no-cjit-no-put-stack-validate
	stress/array-iterators-next-with-call.js.ftl-no-cjit-small-pool
	stress/array-iterators-next-with-call.js.ftl-no-cjit-validate-sampling-profiler
	stress/array-iterators-next-with-call.js.no-cjit-validate-phases
	stress/array-iterators-next-with-call.js.no-llint

<https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20JSC%20%28Tests%29/builds/5634/steps/jscore-test/logs/stdio>