Bug 157350 - Improve the grammar of some error messages 'a argument list' => 'an argument list'
Summary: Improve the grammar of some error messages 'a argument list' => 'an argument ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-04 11:51 PDT by Joseph Pecoraro
Modified: 2016-05-04 16:01 PDT (History)
10 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (9.30 KB, patch)
2016-05-04 11:55 PDT, Joseph Pecoraro 		mark.lam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.12 MB, application/zip)
2016-05-04 12:44 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (672.45 KB, application/zip)
2016-05-04 12:48 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews113 for mac-yosemite (1.41 MB, application/zip)
2016-05-04 12:53 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews102 for mac-yosemite (918.20 KB, application/zip)
2016-05-04 13:14 PDT, Build Bot 		no flags Details
[PATCH] For Landing (27.25 KB, patch)
2016-05-04 13:26 PDT, Joseph Pecoraro 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
[PATCH] For Landing (27.24 KB, patch)
2016-05-04 13:30 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-04 11:51:19 PDT 
* SUMMARY
Improve the grammar of some error messages:

The 'a' in all of these should be 'an':

    ... a 'if' condition
    ... a import list
    ... a export list
    ... a object literal
    ... a argument list
Comment 1 Joseph Pecoraro 2016-05-04 11:51:41 PDT 
<rdar://problem/26082108>
Comment 2 Joseph Pecoraro 2016-05-04 11:55:07 PDT 
Created attachment 278109 [details]
[PATCH] Proposed Fix
Comment 3 Mark Lam 2016-05-04 11:58:25 PDT 
Comment on attachment 278109 [details]
[PATCH] Proposed Fix

r=me
Comment 4 Build Bot 2016-05-04 12:44:06 PDT 
Comment on attachment 278109 [details]
[PATCH] Proposed Fix

Attachment 278109 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1267306

New failing tests:
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T2.html
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.12.html
imported/w3c/web-platform-tests/html/dom/interfaces.html
fast/css/css-selector-text.html
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T1.html
Comment 5 Build Bot 2016-05-04 12:44:09 PDT 
Created attachment 278112 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-05-04 12:48:35 PDT 
Comment on attachment 278109 [details]
[PATCH] Proposed Fix

Attachment 278109 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1267300

New failing tests:
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T2.html
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.12.html
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T1.html
Comment 7 Build Bot 2016-05-04 12:48:38 PDT 
Created attachment 278113 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 8 Build Bot 2016-05-04 12:53:21 PDT 
Comment on attachment 278109 [details]
[PATCH] Proposed Fix

Attachment 278109 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1267309

New failing tests:
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T2.html
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.12.html
fast/css/css-selector-text.html
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T1.html
Comment 9 Build Bot 2016-05-04 12:53:24 PDT 
Created attachment 278114 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Build Bot 2016-05-04 13:14:26 PDT 
Comment on attachment 278109 [details]
[PATCH] Proposed Fix

Attachment 278109 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1267438

New failing tests:
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T2.html
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.12.html
imported/w3c/web-platform-tests/html/dom/interfaces.html
fast/css/css-selector-text.html
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T1.html
Comment 11 Build Bot 2016-05-04 13:14:29 PDT 
Created attachment 278116 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 12 Joseph Pecoraro 2016-05-04 13:26:05 PDT 
Created attachment 278118 [details]
[PATCH] For Landing

Rebaselined the other tests.
Comment 13 WebKit Commit Bot 2016-05-04 13:28:08 PDT 
Comment on attachment 278118 [details]
[PATCH] For Landing

Rejecting attachment 278118 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 278118, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/1267576
Comment 14 Joseph Pecoraro 2016-05-04 13:29:53 PDT 
> ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!.

Oops.
Comment 15 Joseph Pecoraro 2016-05-04 13:30:20 PDT 
Created attachment 278120 [details]
[PATCH] For Landing
Comment 16 WebKit Commit Bot 2016-05-04 14:04:39 PDT 
Comment on attachment 278120 [details]
[PATCH] For Landing

Clearing flags on attachment: 278120

Committed r200429: <http://trac.webkit.org/changeset/200429>