Bug 157350 – Improve the grammar of some error messages 'a argument list' => 'an argument list'

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Joseph Pecoraro]

* SUMMARY
Improve the grammar of some error messages:

The 'a' in all of these should be 'an':

    ... a 'if' condition
    ... a import list
    ... a export list
    ... a object literal
    ... a argument list

[Joseph Pecoraro]

<rdar://problem/26082108>

[Joseph Pecoraro]

Created attachment 278109 [details]
[PATCH] Proposed Fix

[Mark Lam]

Comment on attachment 278109 [details]
[PATCH] Proposed Fix

r=me

[Build Bot]

Comment on attachment 278109 [details]
[PATCH] Proposed Fix

Attachment 278109 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1267306

New failing tests:
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T2.html
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.12.html
imported/w3c/web-platform-tests/html/dom/interfaces.html
fast/css/css-selector-text.html
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T1.html

[Build Bot]

Created attachment 278112 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278109 [details]
[PATCH] Proposed Fix

Attachment 278109 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1267300

New failing tests:
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T2.html
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.12.html
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T1.html

[Build Bot]

Created attachment 278113 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Build Bot]

Comment on attachment 278109 [details]
[PATCH] Proposed Fix

Attachment 278109 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1267309

New failing tests:
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T2.html
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.12.html
fast/css/css-selector-text.html
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T1.html

[Build Bot]

Created attachment 278114 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278109 [details]
[PATCH] Proposed Fix

Attachment 278109 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1267438

New failing tests:
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T2.html
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.12.html
imported/w3c/web-platform-tests/html/dom/interfaces.html
fast/css/css-selector-text.html
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T1.html

[Build Bot]

Created attachment 278116 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Joseph Pecoraro]

Created attachment 278118 [details]
[PATCH] For Landing

Rebaselined the other tests.

[WebKit Commit Bot]

Comment on attachment 278118 [details]
[PATCH] For Landing

Rejecting attachment 278118 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 278118, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/1267576

[Joseph Pecoraro]

> ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!.

Oops.

[Joseph Pecoraro]

Created attachment 278120 [details]
[PATCH] For Landing

[WebKit Commit Bot]

Comment on attachment 278120 [details]
[PATCH] For Landing

Clearing flags on attachment: 278120

Committed r200429: <http://trac.webkit.org/changeset/200429>