Bug 157332 - Add VideoControlsManager tests
Summary: Add VideoControlsManager tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-03 18:12 PDT by Beth Dakin
Modified: 2016-05-03 18:46 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.42 MB, patch)
2016-05-03 18:20 PDT, Beth Dakin
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2016-05-03 18:12:25 PDT
Add VideoControlsManager tests

rdar://problem/24358431
Comment 1 Beth Dakin 2016-05-03 18:20:52 PDT
Created attachment 278052 [details]
Patch
Comment 2 Sam Weinig 2016-05-03 18:34:15 PDT
Comment on attachment 278052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278052&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:256
> +- (BOOL)_hasActiveVideoForControlsManager WK_AVAILABLE(WK_MAC_TBA, NA);

This can be an @property
Comment 3 Beth Dakin 2016-05-03 18:46:40 PDT
Thanks Sam! http://trac.webkit.org/changeset/200403