Bug 157328 - Create console object lazily
Summary: Create console object lazily
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-03 15:51 PDT by Joseph Pecoraro
Modified: 2016-05-05 00:53 PDT (History)
9 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (2.91 KB, patch)
2016-05-03 15:51 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (3.40 KB, patch)
2016-05-03 16:05 PDT, Joseph Pecoraro
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (912.89 KB, application/zip)
2016-05-03 17:05 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1009.06 KB, application/zip)
2016-05-03 17:07 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews116 for mac-yosemite (1.65 MB, application/zip)
2016-05-03 17:16 PDT, Build Bot
no flags Details
[PATCH] Proposed Fix (3.37 KB, patch)
2016-05-04 19:38 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-03 15:51:10 PDT
Create console object lazily.

It landed right around the time of the rest of the lazy initialization. This can also be made lazy.
Comment 1 Joseph Pecoraro 2016-05-03 15:51:46 PDT
Created attachment 278036 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2016-05-03 15:52:54 PDT
Comment on attachment 278036 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=278036&action=review

> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:-637
> -    putDirectWithoutTransition(vm, vm.propertyNames->console, ConsoleObject::create(vm, this, ConsoleObject::createStructure(vm, this, m_objectPrototype.get())), DontEnum);

Oo, looks like we can get rid of the CommonIdentifier too.
Comment 3 Joseph Pecoraro 2016-05-03 16:05:55 PDT
Created attachment 278038 [details]
[PATCH] Proposed Fix
Comment 4 Build Bot 2016-05-03 17:05:23 PDT
Comment on attachment 278038 [details]
[PATCH] Proposed Fix

Attachment 278038 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1262902

New failing tests:
fast/dom/Window/window-lookup-precedence.html
plugins/mouse-events.html
Comment 5 Build Bot 2016-05-03 17:05:27 PDT
Created attachment 278045 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-05-03 17:07:50 PDT
Comment on attachment 278038 [details]
[PATCH] Proposed Fix

Attachment 278038 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1262904

New failing tests:
fast/dom/Window/window-lookup-precedence.html
plugins/mouse-events.html
Comment 7 Build Bot 2016-05-03 17:07:53 PDT
Created attachment 278046 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-05-03 17:16:26 PDT
Comment on attachment 278038 [details]
[PATCH] Proposed Fix

Attachment 278038 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1262898

New failing tests:
fast/dom/Window/window-lookup-precedence.html
plugins/mouse-events.html
Comment 9 Build Bot 2016-05-03 17:16:29 PDT
Created attachment 278048 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Joseph Pecoraro 2016-05-03 18:21:32 PDT
> The attached test failures were seen while running run-webkit-tests on the
> mac-debug-ews.

These failures appear to be a legitimate bug with the lazy initialization. Filed bug 157333.
Comment 11 Joseph Pecoraro 2016-05-04 19:38:52 PDT
Created attachment 278153 [details]
[PATCH] Proposed Fix

Now that the other issue has been addressed, lets try it again!
Comment 12 Geoffrey Garen 2016-05-05 00:04:35 PDT
Comment on attachment 278153 [details]
[PATCH] Proposed Fix

r=me
Comment 13 WebKit Commit Bot 2016-05-05 00:53:36 PDT
Comment on attachment 278153 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 278153

Committed r200452: <http://trac.webkit.org/changeset/200452>
Comment 14 WebKit Commit Bot 2016-05-05 00:53:41 PDT
All reviewed patches have been landed.  Closing bug.