Bug 157328 – Create console object lazily

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Joseph Pecoraro]

Create console object lazily.

It landed right around the time of the rest of the lazy initialization. This can also be made lazy.

[Joseph Pecoraro]

Created attachment 278036 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 278036 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=278036&action=review

> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:-637
> -    putDirectWithoutTransition(vm, vm.propertyNames->console, ConsoleObject::create(vm, this, ConsoleObject::createStructure(vm, this, m_objectPrototype.get())), DontEnum);

Oo, looks like we can get rid of the CommonIdentifier too.

[Joseph Pecoraro]

Created attachment 278038 [details]
[PATCH] Proposed Fix

[Build Bot]

Comment on attachment 278038 [details]
[PATCH] Proposed Fix

Attachment 278038 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1262902

New failing tests:
fast/dom/Window/window-lookup-precedence.html
plugins/mouse-events.html

[Build Bot]

Created attachment 278045 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278038 [details]
[PATCH] Proposed Fix

Attachment 278038 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1262904

New failing tests:
fast/dom/Window/window-lookup-precedence.html
plugins/mouse-events.html

[Build Bot]

Created attachment 278046 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278038 [details]
[PATCH] Proposed Fix

Attachment 278038 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1262898

New failing tests:
fast/dom/Window/window-lookup-precedence.html
plugins/mouse-events.html

[Build Bot]

Created attachment 278048 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Joseph Pecoraro]

> The attached test failures were seen while running run-webkit-tests on the
> mac-debug-ews.

These failures appear to be a legitimate bug with the lazy initialization. Filed bug 157333.

[Joseph Pecoraro]

Created attachment 278153 [details]
[PATCH] Proposed Fix

Now that the other issue has been addressed, lets try it again!

[Geoffrey Garen]

Comment on attachment 278153 [details]
[PATCH] Proposed Fix

r=me

[WebKit Commit Bot]

Comment on attachment 278153 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 278153

Committed r200452: <http://trac.webkit.org/changeset/200452>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.