Bug 157316 - Web Inspector: Simplify console.clear
Summary: Web Inspector: Simplify console.clear
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-05-03 11:15 PDT by Joseph Pecoraro
Modified: 2016-05-03 18:54 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (8.54 KB, patch)
2016-05-03 11:17 PDT, Joseph Pecoraro 		timothy: review+
Details | Formatted Diff | Diff
[PATCH] Proposed Fix (5.14 KB, patch)
2016-05-03 13:36 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-03 11:15:53 PDT 
* SUMMARY
Miscellaneous console tweaks.

  - console.assert.length should be 1, it expects at least one argument
  - console.clear doesn't take any arguments, so clean up that path
Comment 1 Joseph Pecoraro 2016-05-03 11:17:27 PDT 
Created attachment 278009 [details]
[PATCH] Proposed Fix
Comment 2 Timothy Hatcher 2016-05-03 11:29:11 PDT 
Comment on attachment 278009 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=278009&action=review

> LayoutTests/js/console.html:43
> +    if (property === "assert")
> +        shouldBe(`console.${property}.length`, '1');
> +    else
> +        shouldBe(`console.${property}.length`, '0');

I would expect them all to be 1. Hmm.
Comment 3 Joseph Pecoraro 2016-05-03 13:35:58 PDT 
Retitling. I'm not changing assert here.
Comment 4 Joseph Pecoraro 2016-05-03 13:36:58 PDT 
Created attachment 278014 [details]
[PATCH] Proposed Fix
Comment 5 WebKit Commit Bot 2016-05-03 18:54:02 PDT 
Comment on attachment 278014 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 278014

Committed r200404: <http://trac.webkit.org/changeset/200404>
Comment 6 WebKit Commit Bot 2016-05-03 18:54:06 PDT 
All reviewed patches have been landed.  Closing bug.