WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED CONFIGURATION CHANGED
157313
Implement the Wasm object in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=157313
Summary
Implement the Wasm object in WebAssembly
Xan Lopez
Reported
2016-05-03 09:47:03 PDT
I have a WIP patch that implements the Wasm global object with its instiantiateModule method, using the existing parsing functions available. It's enough to get the main WebAssembly demo () loading, but I get some errors during the process. I'm guessing either format changes or missing functionality in our implementation. I'll upload what I have shortly to see if the general approach seems sensible.
Attachments
Wasm object
(11.67 KB, patch)
2016-05-25 07:23 PDT
,
Xan Lopez
no flags
Details
Formatted Diff
Diff
First WIP patch for WASM Module Parser
(16.88 KB, patch)
2016-05-25 07:27 PDT
,
Xan Lopez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Xan Lopez
Comment 1
2016-05-03 09:47:42 PDT
Sorry, the demo is:
https://webassembly.github.io/demo/
Xan Lopez
Comment 2
2016-05-25 07:23:31 PDT
Created
attachment 279768
[details]
Wasm object First WIP patch for comments. This just adds a Wasm object with a instantiateModule method, per the new version of the spec.
Xan Lopez
Comment 3
2016-05-25 07:27:03 PDT
Created
attachment 279769
[details]
First WIP patch for WASM Module Parser First WIP patch of the module parser. The spec has changed quite a bit since the last updates to our code. Relevant comments: - I have modified the wasm-module.js test file from Gecko, since I could not find a polyfill-like prototype that could output the latest version of the wasm binary format (?). - Most of the changes are easily done continuining the previous structure of the code. Most relevant thing is that I'm doing some backtracking in case I fail to read the section that should come next. This could be done without backtracking at all, but it seemed simple enough to do it like this for a first test. Uploading just the first reworked section parsing for comments, but all the others could be done in a similar way.
Xan Lopez
Comment 4
2016-05-25 07:33:29 PDT
Another bit: - Right now all errors are reported as SyntaxError, but it would be nicer to be more nuanced about it. Gecko does that and it's probably pretty helpful for programmers when debugging their code.
JF Bastien
Comment 5
2017-03-13 09:47:24 PDT
This is now obsolete.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug