Bug 157308 - Rename JSKeyValueIterator as JSDOMIterator
Summary: Rename JSKeyValueIterator as JSDOMIterator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-03 05:21 PDT by youenn fablet
Modified: 2016-05-04 01:21 PDT (History)
3 users (show)

See Also:

Attachments
Patch (19.90 KB, patch)
2016-05-03 05:23 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-05-03 05:21:21 PDT 
With some improvements, JSKeyValueIterator may handle set iterators as well as map iterators.
As a first step, it might be good to rename it as JSDOMIterator.
Comment 1 youenn fablet 2016-05-03 05:23:23 PDT 
Created attachment 277989 [details]
Patch
Comment 2 WebKit Commit Bot 2016-05-03 17:28:28 PDT 
Attachment 277989 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMIterator.h:58:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2016-05-04 01:21:41 PDT 
Comment on attachment 277989 [details]
Patch

Clearing flags on attachment: 277989

Committed r200411: <http://trac.webkit.org/changeset/200411>
Comment 4 WebKit Commit Bot 2016-05-04 01:21:44 PDT 
All reviewed patches have been landed.  Closing bug.