Bug 157303 - [TexMap] Clean up TextureMapperGLData, TextureMapperGLData::SharedGLData
Summary: [TexMap] Clean up TextureMapperGLData, TextureMapperGLData::SharedGLData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-03 00:07 PDT by Zan Dobersek
Modified: 2016-05-04 03:29 PDT (History)
6 users (show)

See Also:

Attachments
Patch (13.87 KB, patch)
2016-05-03 00:18 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2016-05-03 00:07:30 PDT 
[TexMap] Clean up TextureMapperGL, TextureMapperGL::SharedGLData
Comment 1 Zan Dobersek 2016-05-03 00:18:42 PDT 
Created attachment 277984 [details]
Patch
Comment 2 WebKit Commit Bot 2016-05-03 17:27:20 PDT 
Attachment 277984 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:161:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zan Dobersek 2016-05-04 00:35:39 PDT 
Comment on attachment 277984 [details]
Patch

Clearing flags on attachment: 277984

Committed r200407: <http://trac.webkit.org/changeset/200407>
Comment 4 Zan Dobersek 2016-05-04 00:35:48 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2016-05-04 03:03:36 PDT 
(In reply to comment #3)
> Comment on attachment 277984 [details]
> Patch
> 
> Clearing flags on attachment: 277984
> 
> Committed r200407: <http://trac.webkit.org/changeset/200407>

It made 50+ tests crash on EFL and made the bot early exit:
https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/27849

(note: I'm not interested in EFL port at all, I just noticed 
and reported this bug, and cc-ed EFL port maintainers.)
Comment 6 Zan Dobersek 2016-05-04 03:29:52 PDT 
(In reply to comment #5)
> (In reply to comment #3)
> > Comment on attachment 277984 [details]
> > Patch
> > 
> > Clearing flags on attachment: 277984
> > 
> > Committed r200407: <http://trac.webkit.org/changeset/200407>
> 
> It made 50+ tests crash on EFL and made the bot early exit:
> https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/
> builds/27849
> 
> (note: I'm not interested in EFL port at all, I just noticed 
> and reported this bug, and cc-ed EFL port maintainers.)

Should be fixed with r200413.
https://trac.webkit.org/r200413