RESOLVED FIXED 157303
[TexMap] Clean up TextureMapperGLData, TextureMapperGLData::SharedGLData 
https://bugs.webkit.org/show_bug.cgi?id=157303
Summary [TexMap] Clean up TextureMapperGLData, TextureMapperGLData::SharedGLData
Zan Dobersek
Reported 2016-05-03 00:07:30 PDT
[TexMap] Clean up TextureMapperGL, TextureMapperGL::SharedGLData
Attachments
Patch (13.87 KB, patch)
2016-05-03 00:18 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2016-05-03 00:18:42 PDT
Created attachment 277984 [details] Patch
WebKit Commit Bot
Comment 2 2016-05-03 17:27:20 PDT
Attachment 277984 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:161: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 3 2016-05-04 00:35:39 PDT
Comment on attachment 277984 [details] Patch Clearing flags on attachment: 277984 Committed r200407: <http://trac.webkit.org/changeset/200407>
Zan Dobersek
Comment 4 2016-05-04 00:35:48 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 5 2016-05-04 03:03:36 PDT
(In reply to comment #3) > Comment on attachment 277984 [details] > Patch > > Clearing flags on attachment: 277984 > > Committed r200407: <http://trac.webkit.org/changeset/200407> It made 50+ tests crash on EFL and made the bot early exit: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/27849 (note: I'm not interested in EFL port at all, I just noticed and reported this bug, and cc-ed EFL port maintainers.)
Zan Dobersek
Comment 6 2016-05-04 03:29:52 PDT
(In reply to comment #5) > (In reply to comment #3) > > Comment on attachment 277984 [details] > > Patch > > > > Clearing flags on attachment: 277984 > > > > Committed r200407: <http://trac.webkit.org/changeset/200407> > > It made 50+ tests crash on EFL and made the bot early exit: > https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/ > builds/27849 > > (note: I'm not interested in EFL port at all, I just noticed > and reported this bug, and cc-ed EFL port maintainers.) Should be fixed with r200413. https://trac.webkit.org/r200413
Note You need to log in before you can comment on or make changes to this bug.