Bug 157295 - Web Inspector: Allow format specifiers in console.assert and console.trace
Summary: Web Inspector: Allow format specifiers in console.assert and console.trace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-02 20:05 PDT by Joseph Pecoraro
Modified: 2016-05-03 08:23 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.08 KB, patch)
2016-05-02 20:10 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[IMAGE] Assert with Format Strings (96.95 KB, image/png)
2016-05-02 20:12 PDT, Joseph Pecoraro 		no flags Details
[IMAGE] Trace with Format Strings (148.77 KB, image/png)
2016-05-02 20:13 PDT, Joseph Pecoraro 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-02 20:05:19 PDT 
* SUMMARY
Allow format specifiers in console.assert and console.trace

Identified by the evolving spec:
<https://github.com/whatwg/console/issues/4>
<https://github.com/whatwg/console/pull/41>

* TEST
console.assert(false, 'string: %s', 'test');

* ACTUAL
Assertion Failed: string: %s – "test"

* EXPECTED
Assertion failed: string: test
Comment 1 Radar WebKit Bug Importer 2016-05-02 20:06:09 PDT 
<rdar://problem/26056039>
Comment 2 Joseph Pecoraro 2016-05-02 20:10:55 PDT 
Created attachment 277966 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2016-05-02 20:12:05 PDT 
Created attachment 277967 [details]
[IMAGE] Assert with Format Strings
Comment 4 Joseph Pecoraro 2016-05-02 20:13:13 PDT 
Created attachment 277968 [details]
[IMAGE] Trace with Format Strings
Comment 5 WebKit Commit Bot 2016-05-03 08:23:17 PDT 
Comment on attachment 277966 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 277966

Committed r200370: <http://trac.webkit.org/changeset/200370>
Comment 6 WebKit Commit Bot 2016-05-03 08:23:22 PDT 
All reviewed patches have been landed.  Closing bug.