Bug 157291 – File Upload: Photo upload name is always generic (image.jpg)

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Jiewen Tan]

File Upload: Photo upload name is always generic (image.jpg)

[Jiewen Tan]

<rdar://problem/12353008>

[Jiewen Tan]

Created attachment 277957 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 277957 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277957&action=review

Rest of the patch looks good to me.

> Source/WebKit2/Platform/spi/ios/PhotosSPI.h:34
> +#if USE(APPLE_INTERNAL_SDK)
> +
> +#import <Photos/Photos_Private.h>
> +
> +#endif

Seems this should be defining the SPI if someone is building without the Internal SDK. Something like:

----
#if USE(APPLE_INTERNAL_SDK)
...
#else

@class PHAssetOriginalMetadataProperties;

@interface PHAsset ()
- (PHAssetOriginalMetadataProperties *)originalMetadataProperties;
- (void)fetchPropertySetsIfNeeded;
@end

#endif
----

Whatever is enough to get the iso-sim bot building!

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:739
> +        [result[0] fetchPropertySetsIfNeeded];
> +        NSString *originalFilename = [[result[0] originalMetadataProperties] originalFilename];
> +        ASSERT(originalFilename);

This code is doing a lot of result[0], which is probably non-optimal. Could that be stored into a temporary variable?

PHAsset *firstAsset = result[0];

[Jiewen Tan]

Created attachment 277970 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 277970 [details]
Patch

Clearing flags on attachment: 277970

Committed r200395: <http://trac.webkit.org/changeset/200395>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.