Bug 157280 - Web Inspector: Unexpected "Script Element #" resources in Debugger Sidebar
Summary: Web Inspector: Unexpected "Script Element #" resources in Debugger Sidebar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-05-02 14:20 PDT by Joseph Pecoraro
Modified: 2016-05-10 17:20 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.63 KB, patch)
2016-05-02 14:21 PDT, Joseph Pecoraro 		timothy: review+
Details | Formatted Diff | Diff
[PATCH] For Landing (1.66 KB, patch)
2016-05-02 17:19 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-02 14:20:12 PDT 
* SUMMARY
Unexpected "Script Element #" resources in Debugger Sidebar

* STEPS TO REPRODUCE
1. Inspect apple.com
2. Reload
3. Show Debugger tab
  => Unexpected "Script Element 1" and 2 in the sidebar
Comment 1 Joseph Pecoraro 2016-05-02 14:21:49 PDT 
Created attachment 277934 [details]
[PATCH] Proposed Fix
Comment 2 Timothy Hatcher 2016-05-02 15:17:08 PDT 
Comment on attachment 277934 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=277934&action=review

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:456
> +        if (script.dynamicallyAddedScriptElement)
> +            return null;

Does this need to allow them with a sourceURL?
Comment 3 Joseph Pecoraro 2016-05-02 17:16:37 PDT 
(In reply to comment #2)
> Comment on attachment 277934 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=277934&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:456
> > +        if (script.dynamicallyAddedScriptElement)
> > +            return null;
> 
> Does this need to allow them with a sourceURL?

Yes, it probably should!! Good catch.
Comment 4 Joseph Pecoraro 2016-05-02 17:19:29 PDT 
Created attachment 277949 [details]
[PATCH] For Landing
Comment 5 WebKit Commit Bot 2016-05-02 18:33:57 PDT 
Comment on attachment 277949 [details]
[PATCH] For Landing

Clearing flags on attachment: 277949

Committed r200353: <http://trac.webkit.org/changeset/200353>