Bug 157278 - Web Inspector: Prefer "Console Evaluation" to "Eval Code" if we know it was a console evaluation
Summary: Web Inspector: Prefer "Console Evaluation" to "Eval Code" if we know it was a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-02 14:11 PDT by Joseph Pecoraro
Modified: 2016-05-02 16:06 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (4.31 KB, patch)
2016-05-02 14:14 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[IMAGE] Console Evaluation CallFrame in Sidebar (225.50 KB, image/png)
2016-05-02 14:15 PDT, Joseph Pecoraro
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-02 14:11:54 PDT
* SUMMARY
Prefer "Console Evaluation" to "Eval Code" if we know it was a console evaluation.

* STEPS TO REPRODUCE
1. Inspect about:blank
2. Show Debugger Tab
3. Enable break on all exceptions
4. js> throw 'hi'
  => Sidebar shows "Eval Code", I'd prefer to see "Console Evaluation"
Comment 1 Radar WebKit Bug Importer 2016-05-02 14:13:32 PDT
<rdar://problem/26048270>
Comment 2 Joseph Pecoraro 2016-05-02 14:14:45 PDT
Created attachment 277931 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2016-05-02 14:15:07 PDT
Created attachment 277932 [details]
[IMAGE] Console Evaluation CallFrame in Sidebar
Comment 4 WebKit Commit Bot 2016-05-02 16:06:46 PDT
Comment on attachment 277931 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 277931

Committed r200345: <http://trac.webkit.org/changeset/200345>
Comment 5 WebKit Commit Bot 2016-05-02 16:06:50 PDT
All reviewed patches have been landed.  Closing bug.