Bug 157271 - Add to the Animations log channel output about which properties are being blended
Summary: Add to the Animations log channel output about which properties are being ble...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-02 11:59 PDT by Simon Fraser (smfr)
Modified: 2016-05-02 15:20 PDT (History)
2 users (show)

See Also:

Attachments
Patch (35.62 KB, patch)
2016-05-02 12:01 PDT, Simon Fraser (smfr) 		dino: review+
Details | Formatted Diff | Diff
For EWS (41.11 KB, patch)
2016-05-02 12:48 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-05-02 11:59:29 PDT 
Add to the Animations log channel output about which properties are being blended
Comment 1 Simon Fraser (smfr) 2016-05-02 12:01:38 PDT 
Created attachment 277920 [details]
Patch
Comment 2 WebKit Commit Bot 2016-05-02 12:02:36 PDT 
Attachment 277920 [details] did not pass style-queue:


ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:428:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:740:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:865:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:907:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1084:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1130:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1169:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1238:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 8 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dean Jackson 2016-05-02 12:08:08 PDT 
Comment on attachment 277920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=277920&action=review

> Source/WebCore/CMakeLists.txt:2112
> +    platform/LengthBox.cpp

I think you forgot to include this file in your patch.

> Source/WebCore/CMakeLists.txt:2286
> +    platform/graphics/transforms/TransformOperation.cpp

And this one too.
Comment 4 Simon Fraser (smfr) 2016-05-02 12:48:20 PDT 
Created attachment 277924 [details]
For EWS
Comment 5 WebKit Commit Bot 2016-05-02 12:50:53 PDT 
Attachment 277924 [details] did not pass style-queue:


ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:428:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:740:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:865:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:907:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1084:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1130:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1169:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1238:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 8 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Simon Fraser (smfr) 2016-05-02 15:20:59 PDT 
https://trac.webkit.org/r200341