Bug 157245 - document.currentScript must be null when we're executing a script inside a shadow tree
Summary: document.currentScript must be null when we're executing a script inside a sh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 148695
  Show dependency treegraph
 
Reported: 2016-05-01 00:04 PDT by Ryosuke Niwa
Modified: 2016-05-02 12:09 PDT (History)
6 users (show)

See Also:


Attachments
Fixes the bug (6.89 KB, patch)
2016-05-01 23:31 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Removed commented out code (6.75 KB, patch)
2016-05-01 23:32 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-yosemite (982.51 KB, application/zip)
2016-05-02 00:41 PDT, Build Bot
no flags Details
Fixed one more issue (9.85 KB, patch)
2016-05-02 01:59 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Fixed the variable name (10.61 KB, patch)
2016-05-02 02:02 PDT, Ryosuke Niwa
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-05-01 00:04:26 PDT
Otherwise it exposes a node inside a shadow tree to the outside.
Comment 1 Ryosuke Niwa 2016-05-01 23:31:39 PDT
Created attachment 277894 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2016-05-01 23:32:29 PDT
Created attachment 277895 [details]
Removed commented out code
Comment 3 Ryosuke Niwa 2016-05-02 00:29:31 PDT
Comment on attachment 277895 [details]
Removed commented out code

Thanks for the review!
Comment 4 Build Bot 2016-05-02 00:41:26 PDT
Comment on attachment 277895 [details]
Removed commented out code

Attachment 277895 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1254359

New failing tests:
http/tests/misc/async-script.html
http/tests/misc/async-script-removed.html
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/async_010.htm
Comment 5 Build Bot 2016-05-02 00:41:31 PDT
Created attachment 277896 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Ryosuke Niwa 2016-05-02 01:59:42 PDT
The assertion I added is failing due to a spec bug.  Filed https://github.com/whatwg/html/issues/1161 and implemented the proposed solution.
Comment 7 Ryosuke Niwa 2016-05-02 01:59:50 PDT
Created attachment 277898 [details]
Fixed one more issue
Comment 8 Ryosuke Niwa 2016-05-02 02:02:29 PDT
Created attachment 277899 [details]
Fixed the variable name
Comment 9 Ryosuke Niwa 2016-05-02 11:19:07 PDT
Committed r200327: <http://trac.webkit.org/changeset/200327>
Comment 10 Ryosuke Niwa 2016-05-02 12:09:40 PDT
<rdar://problem/26045378>